chore: Migrating to lints 2.0.0. (#1128)

Author: cloudwebrtc

analysis_options.yaml

@@ -1,4 +1,4 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml
 
 linter:
   rules:
@@ -47,3 +47,4 @@ analyzer:
     sdk_version_async_exported_from_core: ignore
     # Conflict with import_sorter
     directives_ordering: ignore
+    constant_identifier_names: ignore

lib/src/helper.dart

@@ -91,8 +91,8 @@ class Helper {
     if (deviceId == null) throw 'You need to specify the deviceId';
     if (stream == null) throw 'You need to specify the stream';
 
-    var _cameras = await cameras;
-    if (!_cameras.any((e) => e.deviceId == deviceId)) {
+    var cams = await cameras;
+    if (!cams.any((e) => e.deviceId == deviceId)) {
       throw 'The provided deviceId is not available, make sure to retreive the deviceId from Helper.cammeras()';
     }
 
@@ -108,10 +108,10 @@ class Helper {
       'video': {'deviceId': deviceId}
     };
 
-    var _stream = await openCamera(mediaConstraints);
-    var _cameraTrack = _stream.getVideoTracks()[0];
+    var newStream = await openCamera(mediaConstraints);
+    var newCamTrack = newStream.getVideoTracks()[0];
 
-    await stream.addTrack(_cameraTrack, addToNative: true);
+    await stream.addTrack(newCamTrack, addToNative: true);
 
     return Future.value(true);
   }

lib/src/media_recorder.dart

@@ -1,10 +1,10 @@
-import 'package:webrtc_interface/webrtc_interface.dart' as _interface;
+import 'package:webrtc_interface/webrtc_interface.dart' as rtc;
 
 import '../flutter_webrtc.dart';
 
-class MediaRecorder extends _interface.MediaRecorder {
+class MediaRecorder extends rtc.MediaRecorder {
   MediaRecorder() : _delegate = mediaRecorder();
-  final _interface.MediaRecorder _delegate;
+  final rtc.MediaRecorder _delegate;
 
   @override
   Future<void> start(String path,

lib/src/native/media_stream_impl.dart

@@ -20,16 +20,16 @@ class MediaStreamNative extends MediaStream {
   void setMediaTracks(List<dynamic> audioTracks, List<dynamic> videoTracks) {
     _audioTracks.clear();
 
-    audioTracks.forEach((track) {
+    for (var track in audioTracks) {
       _audioTracks.add(MediaStreamTrackNative(
           track['id'], track['label'], track['kind'], track['enabled']));
-    });
+    }
 
     _videoTracks.clear();
-    videoTracks.forEach((track) {
+    for (var track in videoTracks) {
       _videoTracks.add(MediaStreamTrackNative(
           track['id'], track['label'], track['kind'], track['enabled']));
-    });
+    }
   }
 
   @override
@@ -88,7 +88,7 @@ class MediaStreamNative extends MediaStream {
   }
 
   @override
-  Future<Null> dispose() async {
+  Future<void> dispose() async {
     await WebRTC.invokeMethod(
       'streamDispose',
       <String, dynamic>{'streamId': id},

lib/src/native/media_stream_track_impl.dart

@@ -77,10 +77,10 @@ class MediaStreamTrackNative extends MediaStreamTrack {
       'captureFrame',
       <String, dynamic>{
         'trackId': _trackId,
-        'path': filePath.path + '/captureFrame.png'
+        'path': '${filePath.path}/captureFrame.png'
       },
     );
-    return File(filePath.path + '/captureFrame.png')
+    return File('${filePath.path}/captureFrame.png')
         .readAsBytes()
         .then((value) => value.buffer);
   }
@@ -89,9 +89,9 @@ class MediaStreamTrackNative extends MediaStreamTrack {
   Future<void> applyConstraints([Map<String, dynamic>? constraints]) {
     if (constraints == null) return Future.value();
 
-    var _current = getConstraints();
+    var current = getConstraints();
     if (constraints.containsKey('volume') &&
-        _current['volume'] != constraints['volume']) {
+        current['volume'] != constraints['volume']) {
       Helper.setVolume(constraints['volume'], this);
     }
 

lib/src/native/mediadevices_impl.dart

@@ -87,8 +87,8 @@ class MediaDeviceNative extends MediaDevices {
 
   @override
   Future<List<MediaDeviceInfo>> enumerateDevices() async {
-    var _source = await getSources();
-    return _source
+    var source = await getSources();
+    return source
         .map(
           (e) => MediaDeviceInfo(
               deviceId: e['deviceId'],

lib/src/native/rtc_data_channel_impl.dart

@@ -30,6 +30,7 @@ class RTCDataChannelNative extends RTCDataChannel {
   final String _label;
   int _bufferedAmount = 0;
   @override
+  // ignore: overridden_fields
   int? bufferedAmountLowThreshold;
 
   /// Id for the datachannel in the Flutter <-> Native layer.

lib/src/native/rtc_peerconnection_impl.dart

@@ -371,16 +371,16 @@ class RTCPeerConnectionNative extends RTCPeerConnection {
     try {
       final response = await WebRTC.invokeMethod('getStats', <String, dynamic>{
         'peerConnectionId': _peerConnectionId,
-        'trackId': track != null ? track.id : null
+        'trackId': track?.id
       });
 
       var stats = <StatsReport>[];
       if (response != null) {
         List<dynamic> reports = response['stats'];
-        reports.forEach((report) {
+        for (var report in reports) {
           stats.add(StatsReport(report['id'], report['type'],
               (report['timestamp'] as num).toDouble(), report['values']));
-        });
+        }
       }
       return stats;
     } on PlatformException catch (e) {

lib/src/native/rtc_rtp_receiver_impl.dart

@@ -35,10 +35,10 @@ class RTCRtpReceiverNative extends RTCRtpReceiver {
       var stats = <StatsReport>[];
       if (response != null) {
         List<dynamic> reports = response['stats'];
-        reports.forEach((report) {
+        for (var report in reports) {
           stats.add(StatsReport(report['id'], report['type'],
               report['timestamp'], report['values']));
-        });
+        }
       }
       return stats;
     } on PlatformException catch (e) {

lib/src/native/rtc_rtp_sender_impl.dart

@@ -52,10 +52,10 @@ class RTCRtpSenderNative extends RTCRtpSender {
       var stats = <StatsReport>[];
       if (response != null) {
         List<dynamic> reports = response['stats'];
-        reports.forEach((report) {
+        for (var report in reports) {
           stats.add(StatsReport(report['id'], report['type'],
               report['timestamp'], report['values']));
-        });
+        }
       }
       return stats;
     } on PlatformException catch (e) {

lib/src/web/rtc_video_renderer_impl.dart

@@ -210,7 +210,9 @@ class RTCVideoRenderer extends ValueNotifier<RTCVideoValue>
   @override
   Future<void> dispose() async {
     _srcObject = null;
-    _subscriptions.forEach((s) => s.cancel());
+    for (var s in _subscriptions) {
+      s.cancel();
+    }
     final element = findHtmlView();
     element?.removeAttribute('src');
     element?.load();
@@ -244,7 +246,9 @@ class RTCVideoRenderer extends ValueNotifier<RTCVideoValue>
     // ignore: undefined_prefixed_name
     ui.platformViewRegistry.registerViewFactory('RTCVideoRenderer-$textureId',
         (int viewId) {
-      _subscriptions.forEach((s) => s.cancel());
+      for (var s in _subscriptions) {
+        s.cancel();
+      }
       _subscriptions.clear();
 
       final element = html.VideoElement()

lib/src/web/rtc_video_view_impl.dart

@@ -23,11 +23,11 @@ class RTCVideoView extends StatefulWidget {
   final FilterQuality filterQuality;
 
   @override
-  _RTCVideoViewState createState() => _RTCVideoViewState();
+  RTCVideoViewState createState() => RTCVideoViewState();
 }
 
-class _RTCVideoViewState extends State<RTCVideoView> {
-  _RTCVideoViewState();
+class RTCVideoViewState extends State<RTCVideoView> {
+  RTCVideoViewState();
 
   RTCVideoRenderer get videoRenderer => widget._renderer;
 

pubspec.yaml

@@ -17,6 +17,7 @@ dev_dependencies:
   flutter_test:
     sdk: flutter
   import_sorter: ^4.6.0
+  lints: ^2.0.0
   pedantic: ^1.11.1
   test: any
 

test/unit/rtc_peerconnection_test.dart

@@ -50,7 +50,7 @@ void main() {
       });
     };
 
-    events.forEach((event) {
+    for (var event in events) {
       pc.eventListener(<String, dynamic>{
         'event': event,
 
@@ -79,6 +79,6 @@ void main() {
         'label': '',
         'flutterId': '',
       });
-    });
+    }
   });
 }