better typescript lib

Author: cyrilletuzi

lib/src/lib/databases/localstorage-database.ts

@@ -70,20 +70,23 @@ export class LocalStorageDatabase implements LocalDatabase {
    * @param data The item's value
    * @returns A RxJS `Observable` to wait the end of the operation
    */
-  set(key: string, data: unknown): Observable<undefined> {
+  set(key: string, data: object): Observable<undefined> {
 
-    let serializedData: string | null = null;
+    let serializedData: StringifyResult<object> | null = null;
 
     /* Check if data can be serialized */
-    const dataPrototype: unknown = Object.getPrototypeOf(data);
-    if ((typeof data === "object") && (data !== null) && !Array.isArray(data) &&
+    const dataPrototype = Object.getPrototypeOf(data);
+    if ((typeof data === "object") && !Array.isArray(data) &&
       !((dataPrototype === Object.prototype) || (dataPrototype === null))) {
       return throwError(() => new SerializationError());
     }
 
     /* Try to stringify (can fail on circular references) */
     try {
       serializedData = JSON.stringify(data);
+      if (serializedData === undefined) {
+        throw new Error();
+      }
     } catch (error) {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
       return throwError(() => error as TypeError);

lib/src/lib/validation/json-validator.ts

@@ -194,6 +194,7 @@ export class JSONValidator {
     if (Array.isArray(schema.items) || schema.items === undefined) {
 
       // TODO: cast should not be needed here
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
       return this.validateTuple(data, schema.items as JSONSchema[] | undefined);
 
     }

package-lock.json

@@ -45,6 +45,7 @@
     "@sinclair/typebox": "^0.34.4",
     "@types/jasmine": "~5.1.1",
     "angular-eslint": "^18.4.1",
+    "better-typescript-lib": "~2.9.0",
     "copyfiles": "^2.4.1",
     "eslint": "^9.15.0",
     "jasmine-core": "~5.4.0",