Merge pull request #1019 from cyrilletuzi:bettertslib

better typescript lib

Author: cyrilletuzi

.github/workflows/main.yml

@@ -55,7 +55,7 @@ jobs:
     - name: Build the lib (with the current version, as it is what is published on npm)
       run: npm run build
     - name: Downgrade dependencies to minimal required version
-      run: npm install [email protected] [email protected] [email protected] [email protected] @angular/common@next @angular/compiler@next @angular/core@next @angular/platform-browser@next @angular/router@next @angular/cli@next @angular/compiler-cli@next @angular-devkit/build-angular@next --legacy-peer-deps
+      run: npm install [email protected] [email protected] [email protected] [email protected] @angular/common@19.0.0 @angular/compiler@19.0.0 @angular/core@19.0.0 @angular/platform-browser@19.0.0 @angular/router@19.0.0 @angular/cli@19.0.0 @angular/compiler-cli@19.0.0 @angular-devkit/build-angular@19.0.0 --legacy-peer-deps
       env:
         CI: true
     - name: Run unit tests

lib/src/lib/databases/localstorage-database.ts

@@ -70,20 +70,23 @@ export class LocalStorageDatabase implements LocalDatabase {
    * @param data The item's value
    * @returns A RxJS `Observable` to wait the end of the operation
    */
-  set(key: string, data: unknown): Observable<undefined> {
+  set(key: string, data: object): Observable<undefined> {
 
-    let serializedData: string | null = null;
+    let serializedData: StringifyResult<object> | null = null;
 
     /* Check if data can be serialized */
-    const dataPrototype: unknown = Object.getPrototypeOf(data);
-    if ((typeof data === "object") && (data !== null) && !Array.isArray(data) &&
+    const dataPrototype = Object.getPrototypeOf(data);
+    if ((typeof data === "object") && !Array.isArray(data) &&
       !((dataPrototype === Object.prototype) || (dataPrototype === null))) {
       return throwError(() => new SerializationError());
     }
 
     /* Try to stringify (can fail on circular references) */
     try {
       serializedData = JSON.stringify(data);
+      if (serializedData === undefined) {
+        throw new Error();
+      }
     } catch (error) {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
       return throwError(() => error as TypeError);

lib/src/lib/validation/json-validator.ts

@@ -194,6 +194,7 @@ export class JSONValidator {
     if (Array.isArray(schema.items) || schema.items === undefined) {
 
       // TODO: cast should not be needed here
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
       return this.validateTuple(data, schema.items as JSONSchema[] | undefined);
 
     }

package-lock.json

@@ -45,6 +45,7 @@
     "@sinclair/typebox": "^0.34.4",
     "@types/jasmine": "~5.1.1",
     "angular-eslint": "^18.4.1",
+    "better-typescript-lib": "~2.9.0",
     "copyfiles": "^2.4.1",
     "eslint": "^9.15.0",
     "jasmine-core": "~5.4.0",

package.json

@@ -2,6 +2,8 @@ import { bootstrapApplication } from "@angular/platform-browser";
 import { AppComponent } from "./app/app.component";
 
 bootstrapApplication(AppComponent)
-  .catch((err) => {
+  .then(() => {
+    // Nothing to do
+  }, (err) => {
     console.error(err);
   });

testing-apps/demo/src/main.ts

@@ -7,6 +7,7 @@ import { HomeComponent } from "./app/home/home.component";
 bootstrapApplication(AppComponent, {
   providers: [
     provideRouter([
+      // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
       { path: "lazy", loadChildren: () => import("./app/lazy/routes").then(m => m.routes) },
       { path: "", component: HomeComponent, pathMatch: "full" },
     ]),
@@ -15,6 +16,8 @@ bootstrapApplication(AppComponent, {
     provideIndexedDBStoreName("keyvaluepairs"),
   ],
 })
-  .catch((err) => {
+  .then(() => {
+    // Nothing to do
+  }, (err) => {
     console.error(err);
   });