Skip to content

"yarn type-check" fails. #7386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sainthkh opened this issue May 18, 2020 · 2 comments · Fixed by #7403
Closed

"yarn type-check" fails. #7386

sainthkh opened this issue May 18, 2020 · 2 comments · Fixed by #7403
Labels
topic: typescript

Comments

@sainthkh
Copy link
Contributor

Current behavior:

  1. yarn type-check.
  2. desktop-gui, runner, reporter type checks fail

Desired behavior:

Type check succeeds.

Test code to reproduce

  1. clone develop.
  2. yarn
  3. yarn type-check

Versions

develop branch after #7352.

It's not detected because I accidentally removed the command from CI at #7194

The problem is that we need to break type definition files to make it work.
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label May 18, 2020
@bahmutov bahmutov mentioned this issue May 18, 2020
Merged
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels May 18, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels May 18, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 18, 2020

The code for this is done in cypress-io/cypress#7403, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 20, 2020

Released in 4.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic: typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split types files again cypress-io/cypress
1 participant
@sainthkh