feedback

Author: sainthkh

packages/driver/src/cy/aliases.ts

@@ -75,7 +75,7 @@ export const create = (cy) => ({
     }
 
     if (reserved.includes(alias)) {
-      return $errUtils.throwErrByPath('as.reserved_word', { args: { alias } })
+      $errUtils.throwErrByPath('as.reserved_word', { args: { alias } })
     }
 
     return null
@@ -105,7 +105,7 @@ export const create = (cy) => ({
       ? 'alias.not_registered_with_available'
       : 'alias.not_registered_without_available'
 
-    return $errUtils.throwErrByPath(errPath, {
+    $errUtils.throwErrByPath(errPath, {
       onFail: log,
       args: { cmd, displayName, availableAliases: availableAliases.join(', ') },
     })

packages/driver/src/cy/ensures.ts

@@ -12,10 +12,6 @@ const VALID_POSITIONS = 'topLeft top topRight left center right bottomLeft botto
 // they may need to work with both element arrays, or specific items
 // such as a single element, a single document, or single window
 
-let returnFalse = () => {
-  return false
-}
-
 export const create = (state, expect) => {
   // TODO: we should probably normalize all subjects
   // into an array and loop through each and verify
@@ -156,9 +152,9 @@ export const create = (state, expect) => {
   }
 
   const runVisibilityCheck = (subject, onFail, method) => {
-    if (subject.length !== subject.filter(function () {
-      return !method(this, 'isVisible()', { checkOpacity: false })
-    }).length) {
+    const visibleSubjects = subject.filter(() => !method(this, 'isVisible()', { checkOpacity: false }))
+
+    if (subject.length !== visibleSubjects.length) {
       const cmd = state('current').get('name')
       const reason = $dom.getReasonIsHidden(subject, { checkOpacity: false })
       const node = $dom.stringify(subject)
@@ -244,7 +240,7 @@ export const create = (state, expect) => {
   }
 
   const ensureExistence = (subject) => {
-    returnFalse = () => {
+    const returnFalse = () => {
       cleanup()
 
       return false

packages/driver/src/cy/mouse.ts

@@ -707,8 +707,6 @@ export const create = (state, keyboard, focused, Cypress) => {
   return mouse
 }
 
-export interface Mouse extends ReturnType<typeof create> {}
-
 const { stopPropagation } = window.MouseEvent.prototype
 
 const sendEvent = (evtName, el, evtOptions, bubbles = false, cancelable = false, Constructor, composed = false) => {
@@ -760,3 +758,5 @@ const toCoordsEventOptions = (x, y, win) => {
     layerY: x + scrollY,
   }
 }
+
+export interface Mouse extends ReturnType<typeof create> {}