chore: Update type definitions to match API more closely (#1048)

* chore: Fill out Cypress API types

* chore: Convert Chainable into a Generic with a subject

* chore: undefined return of then keeps Subject

* fix: Remove incorrect comment

* chore: Add element keys to all selector methods

* chore: Remove generic from cy.not - it doesn't make sense

* chore: Add ChainableArray for array Subjects

* chore: Add ChainerArray to thread types through

* chore: Remove ChainableArray interface

* chore: Fix stub/spy types - returns Agent interface

Author: NicholasBoll

cli/package.json

@@ -29,10 +29,14 @@
     "@cypress/xvfb": "1.0.4",
     "@types/blob-util": "1.3.3",
     "@types/bluebird": "3.5.18",
+    "@types/chai": "4.0.8",
+    "@types/chai-jquery": "1.1.35",
     "@types/jquery": "3.2.16",
     "@types/lodash": "4.14.87",
     "@types/minimatch": "3.0.1",
+    "@types/mocha": "2.2.44",
     "@types/sinon": "4.0.0",
+    "@types/sinon-chai": "2.7.29",
     "bluebird": "3.5.0",
     "chalk": "2.1.0",
     "check-more-types": "2.24.0",

cli/types/chai.d.ts

@@ -0,0 +1,13 @@
+// Shim definition to export a namespace. Cypress is actually a global module
+// so import/export isn't allowed there. We import here and define a global module
+// tslint:disable-next-line:no-implicit-dependencies
+import * as chai from 'chai'
+
+export = Chai
+export as namespace Chai
+
+declare namespace Chai {
+  type ChaiStatic = typeof chai
+  type ExpectStatic = typeof chai.expect
+  type AssertStatic = typeof chai.assert
+}