From cf07fac57fc745adeb8eae0eb33b20ef8bc36cca Mon Sep 17 00:00:00 2001 From: coinkits <163612553+coinkits@users.noreply.github.com> Date: Fri, 23 Aug 2024 20:46:13 +0800 Subject: [PATCH] chore: should not reload by default (#423) * feat: remove-reload * test: reload --------- Co-authored-by: cyang Co-authored-by: Chen Yangjian <252317+cyjake@users.noreply.github.com> --- src/bone.js | 3 --- test/integration/suite/json.test.js | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bone.js b/src/bone.js index 5d331a85..967b9a09 100644 --- a/src/bone.js +++ b/src/bone.js @@ -711,9 +711,6 @@ class Bone { } try { const res = await this._update(Object.keys(changes).length? changes : values, options); - if (typeof values === 'object' && Object.values(values).some(v => v instanceof Raw)) { - await this.reload(); - } return res; } catch (error) { // revert value in case update failed diff --git a/test/integration/suite/json.test.js b/test/integration/suite/json.test.js index 20bc6bf5..35e321ab 100644 --- a/test/integration/suite/json.test.js +++ b/test/integration/suite/json.test.js @@ -35,12 +35,14 @@ describe('=> Basic', () => { await gen.update({ extra: { a: 1 } }); assert.equal(gen.extra.a, 1); await gen.jsonMerge('extra', { b: 2, a: 3 }); + await gen.reload(); assert.equal(gen.extra.a, 3); assert.equal(gen.extra.b, 2); const gen2 = await Gen.create({ name: 'gen2', extra: { test: 1 }}); assert.equal(gen2.extra.test, 1); await gen2.jsonMerge('extra', { url: 'https://www.wanxiang.art/?foo=' }); + await gen2.reload(); assert.equal(gen2.extra.url, 'https://www.wanxiang.art/?foo='); }); @@ -51,6 +53,7 @@ describe('=> Basic', () => { const sql = new Raw(`JSON_MERGE_PATCH(extra, '${JSON.stringify({ url: 'https://www.taobao.com/?id=1' })}')`); await gen.update({extra: sql}); + await gen.reload(); assert.equal(gen.extra.url, 'https://www.taobao.com/?id=1'); }); });