Skip to content

Commit 9f49b36

Browse files
mohzulfikarkoba04
andauthored
chore!: drop Node v10 support because of EOL (#425)
BREAKING CHANGE: drop support Node v10 because of the EOL * Update node version on github action * chore: drop support Node v10 because of the EOL * fix: failling test by updating the engine version Co-authored-by: Toru Kobayashi <[email protected]>
1 parent 1c85486 commit 9f49b36

File tree

5 files changed

+16
-13
lines changed

5 files changed

+16
-13
lines changed

.github/workflows/lint.yml

+10-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
name: lint
32

43
on:
@@ -10,14 +9,20 @@ on:
109

1110
jobs:
1211
build:
13-
name: Node.js ubuntu-latest 12.x
14-
runs-on: ubuntu-latest
12+
name: Node.js ${{ matrix.os }} ${{ matrix.node-version }}
13+
runs-on: ${{ matrix.os }}
14+
15+
strategy:
16+
matrix:
17+
node-version: [14.x]
18+
os: [ubuntu-latest]
19+
1520
steps:
1621
- uses: actions/checkout@v2
17-
- name: Use Node.js 12.x
22+
- name: Use Node.js ${{ matrix.node-version }}
1823
uses: actions/setup-node@v2
1924
with:
20-
node-version: 12.x
25+
node-version: ${{ matrix.node-version }}
2126
- name: npm ci, and npm run lint
2227
run: |
2328
npm ci

.github/workflows/test.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
name: test
32

43
on:
@@ -10,13 +9,12 @@ on:
109

1110
jobs:
1211
build:
13-
1412
name: Node.js ${{ matrix.os }} ${{ matrix.node-version }}
1513
runs-on: ${{ matrix.os }}
1614

1715
strategy:
1816
matrix:
19-
node-version: [10.x, 12.x]
17+
node-version: [12.x, 14.x, 16.x]
2018
os: [ubuntu-latest]
2119

2220
steps:

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@cybozu/eslint-config",
33
"engines": {
4-
"node": ">=10"
4+
"node": ">=12"
55
},
66
"repository": "cybozu/eslint-config",
77
"homepage": "https://github.com/cybozu/eslint-config",

test/fixtures/node/error.js

+3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
// prettier-ignore
22
require('./unknown');
33

4+
45
(async () => {
56
try {
67
await new Promise(r => r);
78
} catch {
89
console.log(1n);
910
}
1011
})();
12+
13+
exports = {};

test/node-test.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,7 @@ describe("node", () => {
66
const result = await runLintWithFixtures("node");
77
assert.deepStrictEqual(result, {
88
"error.js": {
9-
errors: [
10-
"node/no-missing-require",
11-
"node/no-unsupported-features/es-syntax",
12-
],
9+
errors: ["node/no-missing-require", "node/no-exports-assign"],
1310
},
1411
"ok.js": {},
1512
});

0 commit comments

Comments
 (0)