Skip to content

Commit edfdec7

Browse files
authored
Fix esbuild warning (#2513)
Not totally sure what it's about but this fix makes the warnings go away and doesn't break anything ``` ▲ [WARNING] "./reporters/parallel-buffered" should be marked as external for use with "require.resolve" [require-resolve-not-external] ../../node_modules/.pnpm/[email protected]/node_modules/mocha/lib/nodejs/parallel-buffered-runner.js:19:2: 19 │ './reporters/parallel-buffered' ╵ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ▲ [WARNING] "./worker.js" should be marked as external for use with "require.resolve" [require-resolve-not-external] ../../node_modules/.pnpm/[email protected]/node_modules/mocha/lib/nodejs/buffered-worker-pool.js:16:36: 16 │ const WORKER_PATH = require.resolve('./worker.js'); ╵ ~~~~~~~~~~~~~ ``` ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
1 parent ef04390 commit edfdec7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/test-harness/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"main": "./out/index.js",
77
"scripts": {
88
"test": "env CURSORLESS_MODE=test my-ts-node src/scripts/runTestsCI.ts",
9-
"build:base": "esbuild --sourcemap --conditions=cursorless:bundler --bundle --external:vscode --format=cjs --platform=node",
9+
"build:base": "esbuild --sourcemap --conditions=cursorless:bundler --bundle --external:vscode --external:./reporters/parallel-buffered --external:./worker.js --format=cjs --platform=node",
1010
"build": "pnpm run build:runner && pnpm run build:tests && pnpm run build:unit && pnpm run build:talon",
1111
"build:runner": "pnpm run build:base ./src/runners/extensionTestsVscode.ts --outfile=dist/extensionTestsVscode.cjs",
1212
"build:unit": "pnpm run build:base ./src/scripts/runUnitTestsOnly.ts --outfile=dist/runUnitTestsOnly.cjs",

0 commit comments

Comments
 (0)