consistent-type-imports rule (#2619)

related #2618
revives #1832

vscode quick fix import and auto import appears to be doing the right
thing in regards to type only or runtime imports. Imports organize or
imports fix unfortunately do not convert a runtime import to a type
import if it's only used as a type. We probably need to rely on the
linter to do that part for us.

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Author: AndreasArvidsson

.eslintrc.json

@@ -23,6 +23,7 @@
   ],
   "rules": {
     "import/no-relative-packages": "error",
+    "@typescript-eslint/consistent-type-imports": "error",
     "@typescript-eslint/consistent-type-assertions": [
       "error",
       {

packages/cheatsheet-local/src/app/app.tsx

@@ -1,4 +1,5 @@
-import { CheatsheetPage, CheatsheetInfo } from "@cursorless/cheatsheet";
+import type { CheatsheetInfo } from "@cursorless/cheatsheet";
+import { CheatsheetPage } from "@cursorless/cheatsheet";
 import "../styles.css";
 
 declare global {

packages/cheatsheet/src/lib/cheatsheet.tsx

@@ -6,7 +6,7 @@ import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
 import { faCircleQuestion } from "@fortawesome/free-solid-svg-icons/faCircleQuestion";
 import CheatsheetNotesComponent from "./components/CheatsheetNotesComponent";
 import SmartLink from "./components/SmartLink";
-import { CheatsheetInfo } from "./CheatsheetInfo";
+import type { CheatsheetInfo } from "./CheatsheetInfo";
 
 type CheatsheetPageProps = {
   cheatsheetInfo: CheatsheetInfo;

packages/cheatsheet/src/lib/components/CheatsheetLegendComponent.tsx

@@ -1,5 +1,5 @@
 import * as React from "react";
-import { CheatsheetLegend } from "../cheatsheetLegend";
+import type { CheatsheetLegend } from "../cheatsheetLegend";
 import useIsHighlighted from "../hooks/useIsHighlighted";
 import { formatCaptures } from "./formatCaptures";
 import SmartLink from "./SmartLink";

packages/cheatsheet/src/lib/components/CheatsheetListComponent.tsx

@@ -1,4 +1,4 @@
-import { CheatsheetSection, Variation } from "../CheatsheetInfo";
+import type { CheatsheetSection, Variation } from "../CheatsheetInfo";
 import useIsHighlighted from "../hooks/useIsHighlighted";
 import { formatCaptures } from "./formatCaptures";
 

packages/common/src/FakeCommandServerApi.ts

@@ -1,4 +1,4 @@
-import {
+import type {
   CommandServerApi,
   FocusedElementType,
   InboundSignal,

packages/common/src/ide/fake/FakeCapabilities.ts

@@ -1,4 +1,4 @@
-import { Capabilities } from "../types/Capabilities";
+import type { Capabilities } from "../types/Capabilities";
 
 export class FakeCapabilities implements Capabilities {
   commands = {

packages/common/src/ide/fake/FakeConfiguration.ts

@@ -1,13 +1,13 @@
 import { get } from "lodash-es";
 import { Notifier } from "../../util/Notifier";
-import {
+import type {
   Configuration,
   ConfigurationScope,
-  CONFIGURATION_DEFAULTS,
   CursorlessConfigKey,
   CursorlessConfiguration,
 } from "../types/Configuration";
-import { GetFieldType, Paths } from "../types/Paths";
+import { CONFIGURATION_DEFAULTS } from "../types/Configuration";
+import type { GetFieldType, Paths } from "../types/Paths";
 
 interface ConfigurationScopeValues {
   scope: ConfigurationScope;

packages/common/src/ide/fake/FakeIDE.ts

@@ -1,11 +1,11 @@
 import { pull } from "lodash-es";
 import type { EditableTextEditor, TextEditor } from "../..";
-import { GeneralizedRange } from "../../types/GeneralizedRange";
-import { TextDocument } from "../../types/TextDocument";
+import type { GeneralizedRange } from "../../types/GeneralizedRange";
+import type { TextDocument } from "../../types/TextDocument";
 import type { TextDocumentChangeEvent } from "../types/Events";
-import { FlashDescriptor } from "../types/FlashDescriptor";
-import { QuickPickOptions } from "../types/QuickPickOptions";
-import {
+import type { FlashDescriptor } from "../types/FlashDescriptor";
+import type { QuickPickOptions } from "../types/QuickPickOptions";
+import type {
   Event,
   TextEditorSelectionChangeEvent,
   TextEditorVisibleRangesChangeEvent,

packages/common/src/ide/normalized/NormalizedIDE.ts

@@ -1,12 +1,12 @@
-import { GeneralizedRange } from "../../types/GeneralizedRange";
-import { TextEditor } from "../../types/TextEditor";
-import FakeConfiguration from "../fake/FakeConfiguration";
-import FakeKeyValueStore from "../fake/FakeKeyValueStore";
-import { FakeIDE } from "../fake/FakeIDE";
+import type { GeneralizedRange } from "../../types/GeneralizedRange";
+import type { TextEditor } from "../../types/TextEditor";
+import type FakeConfiguration from "../fake/FakeConfiguration";
+import type FakeKeyValueStore from "../fake/FakeKeyValueStore";
+import type { FakeIDE } from "../fake/FakeIDE";
 import PassthroughIDEBase from "../PassthroughIDEBase";
-import { FlashDescriptor } from "../types/FlashDescriptor";
+import type { FlashDescriptor } from "../types/FlashDescriptor";
 import type { IDE } from "../types/ide.types";
-import { QuickPickOptions } from "../types/QuickPickOptions";
+import type { QuickPickOptions } from "../types/QuickPickOptions";
 
 export class NormalizedIDE extends PassthroughIDEBase {
   configuration: FakeConfiguration;