dmaengine: idxd: Avoid unnecessary destruction of file_ida

jira LE-2157
cve CVE-2024-38629
Rebuild_History Non-Buildable kernel-5.14.0-503.14.1.el9_5
commit-author Fenghua Yu <[email protected]>
commit 76e43fa

file_ida is allocated during cdev open and is freed accordingly
during cdev release. This sequence is guaranteed by driver file
operations. Therefore, there is no need to destroy an already empty
file_ida when the WQ cdev is removed.

Worse, ida_free() in cdev release may happen after destruction of
file_ida per WQ cdev. This can lead to accessing an id in file_ida
after it has been destroyed, resulting in a kernel panic.

Remove ida_destroy(&file_ida) to address these issues.

Fixes: e6fd6d7 ("dmaengine: idxd: add a device to represent the file opened")
	Signed-off-by: Lijun Pan <[email protected]>
	Signed-off-by: Fenghua Yu <[email protected]>
	Reviewed-by: Dave Jiang <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
	Signed-off-by: Vinod Koul <[email protected]>
(cherry picked from commit 76e43fa)
	Signed-off-by: Jonathan Maple <[email protected]>

Author: PlaidCat

drivers/dma/idxd/cdev.c

@@ -577,7 +577,6 @@ void idxd_wq_del_cdev(struct idxd_wq *wq)
 	struct idxd_cdev *idxd_cdev;
 
 	idxd_cdev = wq->idxd_cdev;
-	ida_destroy(&file_ida);
 	wq->idxd_cdev = NULL;
 	cdev_device_del(&idxd_cdev->cdev, cdev_dev(idxd_cdev));
 	put_device(cdev_dev(idxd_cdev));