Partial revert of "In essiv_aead_setkey(), use the same logic as crypto_authenc_esn_setkey() to zeroize keys on exit."

LE-3197

A bug was introduced while updating the kernel per atsec’s request. When
key zeroization was added, setting the crypto algorithm key was removed in
error. This re-adds the code to set the crypto key.

Tested under non-FIPS and FIPS mode. NB. This bug only causes the algorithm
to be unusable and an error message returned to users. No corruption or
insecure algorithm use is allowed.

[Sultan: touched up the commit message with what Jeremy wrote]

Signed-off-by: Jason Rodriguez <[email protected]>
Signed-off-by: Jeremy Allison <[email protected]>
Signed-off-by: Sultan Alsawaf <[email protected]>

Author: jason-rodri

crypto/essiv.c

@@ -119,9 +119,11 @@ static int essiv_aead_setkey(struct crypto_aead *tfm, const u8 *key,
 	crypto_cipher_clear_flags(tctx->essiv_cipher, CRYPTO_TFM_REQ_MASK);
 	crypto_cipher_set_flags(tctx->essiv_cipher, crypto_aead_get_flags(tfm) &
 						    CRYPTO_TFM_REQ_MASK);
+	err = crypto_cipher_setkey(tctx->essiv_cipher, salt,
+				   crypto_shash_digestsize(tctx->hash));
 out:
 	memzero_explicit(&keys, sizeof(keys));
-    return err;
+	return err;
 }
 
 static int essiv_aead_setauthsize(struct crypto_aead *tfm,