ovl: fix use inode directly in rcu-walk mode

jira LE-2741
Rebuild_History Non-Buildable kernel-4.18.0-553.42.1.el8_10
commit-author Chen Zhongjin <[email protected]>
commit 672e426

ovl_dentry_revalidate_common() can be called in rcu-walk mode.  As document
said, "in rcu-walk mode, d_parent and d_inode should not be used without
care".

Check inode here to protect access under rcu-walk mode.

Fixes: bccece1 ("ovl: allow remote upper")
Reported-and-tested-by: [email protected]
	Signed-off-by: Chen Zhongjin <[email protected]>
	Cc: <[email protected]> # v5.7
	Signed-off-by: Miklos Szeredi <[email protected]>
(cherry picked from commit 672e426)
	Signed-off-by: Jonathan Maple <[email protected]>

Author: PlaidCat

fs/overlayfs/super.c

@@ -141,11 +141,16 @@ static int ovl_dentry_revalidate_common(struct dentry *dentry,
 					unsigned int flags, bool weak)
 {
 	struct ovl_entry *oe = dentry->d_fsdata;
+	struct inode *inode = d_inode_rcu(dentry);
 	struct dentry *upper;
 	unsigned int i;
 	int ret = 1;
 
-	upper = ovl_dentry_upper(dentry);
+	/* Careful in RCU mode */
+	if (!inode)
+		return -ECHILD;
+
+	upper = ovl_i_dentry_upper(inode);
 	if (upper)
 		ret = ovl_revalidate_real(upper, flags, weak);