Skip to content

Commit a63db07

Browse files
skotur-brcmdavem330
authored andcommitted
bnxt_en: Add missing skb_mark_for_recycle() in bnxt_rx_vlan()
If bnxt_rx_vlan() fails because the VLAN protocol ID is invalid, the SKB is freed but we're missing the call to recycle it. This may cause the warning: "page_pool_release_retry() stalled pool shutdown" Add the missing skb_mark_for_recycle() in bnxt_rx_vlan(). Fixes: 86b0550 ("bnxt_en: Use the unified RX page pool buffers for XDP and non-XDP") Reviewed-by: Kalesh AP <[email protected]> Reviewed-by: Pavan Chebbi <[email protected]> Signed-off-by: Somnath Kotur <[email protected]> Signed-off-by: Michael Chan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 8e6cc90 commit a63db07

File tree

1 file changed

+1
-0
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+1
-0
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2015,6 +2015,7 @@ static struct sk_buff *bnxt_rx_vlan(struct sk_buff *skb, u8 cmp_type,
20152015
}
20162016
return skb;
20172017
vlan_err:
2018+
skb_mark_for_recycle(skb);
20182019
dev_kfree_skb(skb);
20192020
return NULL;
20202021
}

0 commit comments

Comments
 (0)