Skip to content

Commit 65484f9

Browse files
committed
Merge branch 'refactor-phy-reset-handling-and'
Thangaraj Samynathan says: ==================== Refactor PHY reset handling and fix WOL This patch series refines the PHY reset and initialization logic in the lan743x driver. Enhance the robustness of the driver initialization process and prevent WOL-related issues during suspend/resume cycles. ==================== Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
2 parents 3920a75 + 82d1096 commit 65484f9

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

drivers/net/ethernet/microchip/lan743x_main.c

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1330,7 +1330,7 @@ static int lan743x_mac_set_mtu(struct lan743x_adapter *adapter, int new_mtu)
13301330
}
13311331

13321332
/* PHY */
1333-
static int lan743x_phy_reset(struct lan743x_adapter *adapter)
1333+
static int lan743x_hw_reset_phy(struct lan743x_adapter *adapter)
13341334
{
13351335
u32 data;
13361336

@@ -1346,11 +1346,6 @@ static int lan743x_phy_reset(struct lan743x_adapter *adapter)
13461346
50000, 1000000);
13471347
}
13481348

1349-
static int lan743x_phy_init(struct lan743x_adapter *adapter)
1350-
{
1351-
return lan743x_phy_reset(adapter);
1352-
}
1353-
13541349
static void lan743x_phy_interface_select(struct lan743x_adapter *adapter)
13551350
{
13561351
u32 id_rev;
@@ -3534,10 +3529,6 @@ static int lan743x_hardware_init(struct lan743x_adapter *adapter,
35343529
if (ret)
35353530
return ret;
35363531

3537-
ret = lan743x_phy_init(adapter);
3538-
if (ret)
3539-
return ret;
3540-
35413532
ret = lan743x_ptp_init(adapter);
35423533
if (ret)
35433534
return ret;
@@ -3674,6 +3665,10 @@ static int lan743x_pcidev_probe(struct pci_dev *pdev,
36743665
if (ret)
36753666
goto cleanup_pci;
36763667

3668+
ret = lan743x_hw_reset_phy(adapter);
3669+
if (ret)
3670+
goto cleanup_pci;
3671+
36773672
ret = lan743x_hardware_init(adapter, pdev);
36783673
if (ret)
36793674
goto cleanup_pci;

0 commit comments

Comments
 (0)