idpf: fix idpf_vc_core_init error path

jira LE-2522
Rebuild_History Non-Buildable kernel-5.14.0-503.29.1.el9_5
commit-author Pavan Kumar Linga <[email protected]>
commit 9b58031

In an event where the platform running the device control plane
is rebooted, reset is detected on the driver. It releases
all the resources and waits for the reset to complete. Once the
reset is done, it tries to build the resources back. At this
time if the device control plane is not yet started, then
the driver timeouts on the virtchnl message and retries to
establish the mailbox again.

In the retry flow, mailbox is deinitialized but the mailbox
workqueue is still alive and polling for the mailbox message.
This results in accessing the released control queue leading to
null-ptr-deref. Fix it by unrolling the work queue cancellation
and mailbox deinitialization in the reverse order which they got
initialized.

Fixes: 4930fbf ("idpf: add core init and interrupt request")
Fixes: 34c21fa ("idpf: implement virtchnl transaction manager")
	Cc: [email protected] # 6.9+
	Reviewed-by: Tarun K Singh <[email protected]>
	Signed-off-by: Pavan Kumar Linga <[email protected]>
	Tested-by: Krishneil Singh <[email protected]>
	Signed-off-by: Tony Nguyen <[email protected]>
(cherry picked from commit 9b58031)
	Signed-off-by: Jonathan Maple <[email protected]>

Author: PlaidCat

drivers/net/ethernet/intel/idpf/idpf_lib.c

@@ -1803,6 +1803,7 @@ static int idpf_init_hard_reset(struct idpf_adapter *adapter)
 	 */
 	err = idpf_vc_core_init(adapter);
 	if (err) {
+		cancel_delayed_work_sync(&adapter->mbx_task);
 		idpf_deinit_dflt_mbx(adapter);
 		goto unlock_mutex;
 	}

drivers/net/ethernet/intel/idpf/idpf_virtchnl.c

@@ -3022,7 +3022,6 @@ int idpf_vc_core_init(struct idpf_adapter *adapter)
 	adapter->state = __IDPF_VER_CHECK;
 	if (adapter->vcxn_mngr)
 		idpf_vc_xn_shutdown(adapter->vcxn_mngr);
-	idpf_deinit_dflt_mbx(adapter);
 	set_bit(IDPF_HR_DRV_LOAD, adapter->flags);
 	queue_delayed_work(adapter->vc_event_wq, &adapter->vc_event_task,
 			   msecs_to_jiffies(task_delay));