Warn if constrained shuffle exceeds the maximum iteration number

ctrl-labs · Aug 17, 2020 · 66bd2d1 · 66bd2d1
1 parent 463efd7
commit 66bd2d1
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/library/src/util/random/index.js b/packages/library/src/util/random/index.js
@@ -162,11 +162,14 @@ export class Random {
 
     // Shuffle until a candidate matches the constraints,
     // or the maximum number of iterations is reached
-    let candidate
-    for (let i = 0; i < maxIterations; i++) {
+    let candidate, i
+    for (i = 0; i < maxIterations; i++) {
       candidate = this.shuffle(a)
       if (constraintChecker(candidate)) break
     }
+    if (i >= maxIterations) {
+      console.warn(`constrainedShuffle could not find a matching candidate after ${ maxIterations } iterations`)
+    }
     return candidate
   }