Skip to content

clean up clippy warnings #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ctm opened this issue Feb 27, 2022 · 3 comments
Closed

clean up clippy warnings #895

ctm opened this issue Feb 27, 2022 · 3 comments
Assignees
@ctm
Labels
chore Maintenance or other non-bug, non-feature easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon

Comments

@ctm
Copy link
Owner

ctm commented Feb 27, 2022

Fix the clippy warnings that crept in during WYWAE.

Yesterday or the day before brought new clippy warnings. Normally I fix them w/o creating a GitHub issue, but my development cycle was hectic. So now I'm working on other things but don't want to forget.
@ctm ctm added chore Maintenance or other non-bug, non-feature high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile labels Feb 27, 2022
@ctm ctm self-assigned this Feb 27, 2022
@ctm
Copy link
Owner Author

ctm commented Feb 27, 2022

Ugh. clippy is segfaulting. That showed up a few days ago but had seemed to go away, although I also backed off how frequently I was running clippy once it started happening.

Since there are plenty of people reporting this error, I'll just remove the high priority label from this issue and fix the clippy warnings when clippy is running nicely again.

@ctm ctm added easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon and removed high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile labels Feb 27, 2022
@ctm
Copy link
Owner Author

ctm commented Feb 28, 2022

So, a workaround is simply to run clippy over and over. There may be a better way, but that's easy enough to allow me to clean up a bunch of recently added clippy warnings and also fix some code I wrote recently that triggered old clippy warnings.

I've relabeled this as high priority because I really don't want the tech. debt of not fixing these and it appears that clippy may continue to segfault for a while.

@ctm
Copy link
Owner Author

ctm commented Feb 28, 2022

Done. Deploying now.

@ctm ctm closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctm ctm

Labels
chore Maintenance or other non-bug, non-feature easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctm