Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-consistent calculation of concentration parameters #256

Open
jsitarek opened this issue Sep 10, 2024 · 1 comment
Open

Non-consistent calculation of concentration parameters #256

jsitarek opened this issue Sep 10, 2024 · 1 comment

Comments

@jsitarek
Copy link
Collaborator

jsitarek commented Sep 10, 2024

concentration parameters for MAGIC are computed from non cleaned image:

conc_params = concentration_parameters(camera_geom, image, hillas_params)

same is done for MCs (both MAGIC and LST-1):

conc_params = concentration_parameters(
camera_geoms[tel_id], image, hillas_params
)

however for LST this is done after selecting only image pixels:
https://github.com/cta-observatory/cta-lstchain/blob/e4a5b7a36dfd643acf47b9006f51fe882b6dbc5c/lstchain/reco/r0_to_dl1.py#L164

the difference is not huge, but especially if there are multiple islands the concentration parameters can behave in complicated way.

Thankfully the concentration parameters are not used in the standard chain.

There are two possible ways to fix it:

  1. change both for MAGIC data and for MC to have it the same as for LST-1 data
  2. change the behavior for LST-1 MCs to reproduce what is done in the data (which would mean that the parameter would have slightly different meaning for different telescopes)
@jsitarek
Copy link
Collaborator Author

this is the difference between the values of the parameters for the data between LST data (computed from the cleaned image in blue and from full image in orange:
conc2
(computed by @nzywucka )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant