Merge pull request rails#41115 from ghiculescu/failing-test-on-ruby-master

Fix test failing on ruby master

Author: gmcgibbon

activerecord/test/cases/validations/numericality_validation_test.rb

@@ -81,17 +81,45 @@ def self.name
     assert_predicate(subject, :valid?)
   end
 
-  def test_virtual_attribute_with_precision
+  def test_virtual_attribute_with_precision_round_down
     model_class.attribute(:virtual_decimal_number, :decimal, precision: 5)
     model_class.validates_numericality_of(
       :virtual_decimal_number, equal_to: 123.45
     )
 
-    subject = model_class.new(virtual_decimal_number: 123.455)
+    subject = model_class.new(virtual_decimal_number: 123.454)
 
     assert_predicate subject, :valid?
   end
 
+  def test_virtual_attribute_with_precision_round_half_even
+    model_class.attribute(:virtual_decimal_number, :decimal, precision: 5)
+    model_class.validates_numericality_of(
+      :virtual_decimal_number, equal_to: 123.45
+    )
+
+    subject = model_class.new(virtual_decimal_number: 123.455)
+
+    if RUBY_VERSION > "3.0.0"
+      # BigDecimal's to_d behavior changed in BigDecimal 3.0.1, see https://github.com/ruby/bigdecimal/issues/70
+      # TOOD: replace this with a check against BigDecimal::VERSION
+      assert_not_predicate subject, :valid?
+    else
+      assert_predicate subject, :valid?
+    end
+  end
+
+  def test_virtual_attribute_with_precision_round_up
+    model_class.attribute(:virtual_decimal_number, :decimal, precision: 5)
+    model_class.validates_numericality_of(
+      :virtual_decimal_number, equal_to: 123.45
+    )
+
+    subject = model_class.new(virtual_decimal_number: 123.456)
+
+    assert_not_predicate subject, :valid?
+  end
+
   def test_virtual_attribute_with_scale
     model_class.attribute(:virtual_decimal_number, :decimal, scale: 2)
     model_class.validates_numericality_of(