Merge pull request rails#31844 from igorkasyanchuk/add_to_hash_and_to_h_for_session_and_cookies

Consistent behavior for session and cookies with to_h and to_hash method

Author: kamipo

actionpack/lib/action_dispatch/middleware/cookies.rb

@@ -338,6 +338,9 @@ def key?(name)
       end
       alias :has_key? :key?
 
+      # Returns the cookies as Hash.
+      alias :to_hash :to_h
+
       def update(other_hash)
         @cookies.update other_hash.stringify_keys
         self

actionpack/lib/action_dispatch/request/session.rb

@@ -130,6 +130,7 @@ def to_hash
         load_for_read!
         @delegate.dup.delete_if { |_, v| v.nil? }
       end
+      alias :to_h :to_hash
 
       # Updates the session with given Hash.
       #

actionpack/test/dispatch/cookies_test.rb

@@ -36,6 +36,12 @@ def test_key_is_to_s
     assert_equal "bar", request.cookie_jar.fetch(:foo)
   end
 
+  def test_to_hash
+    request.cookie_jar["foo"] = "bar"
+    assert_equal({ "foo" => "bar" }, request.cookie_jar.to_hash)
+    assert_equal({ "foo" => "bar" }, request.cookie_jar.to_h)
+  end
+
   def test_fetch_type_error
     assert_raises(KeyError) do
       request.cookie_jar.fetch(:omglolwut)

actionpack/test/dispatch/request/session_test.rb

@@ -22,6 +22,7 @@ def test_to_hash
         s["foo"] = "bar"
         assert_equal "bar", s["foo"]
         assert_equal({ "foo" => "bar" }, s.to_hash)
+        assert_equal({ "foo" => "bar" }, s.to_h)
       end
 
       def test_create_merges_old