Skip to content

Commit 0f3a895

Browse files
jhawthornseejohnrun
andcommitted
Dont send preload links headers if streaming
Co-authored-by: John Crepezzi <[email protected]>
1 parent 43a0e55 commit 0f3a895

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

actionview/lib/action_view/helpers/asset_tag_helper.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -544,6 +544,7 @@ def resolve_link_as(extname, mime_type)
544544
MAX_HEADER_SIZE = 8_000 # Some HTTP client and proxies have a 8kiB header limit
545545
def send_preload_links_header(preload_links, max_header_size: MAX_HEADER_SIZE)
546546
return if preload_links.empty?
547+
return if response.sending?
547548

548549
if respond_to?(:request) && request
549550
request.send_early_hints("Link" => preload_links.join("\n"))

actionview/test/template/asset_tag_helper_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ class FakeResponse
2424
def headers
2525
@headers ||= {}
2626
end
27+
def sending?; false; end
2728
end
2829

2930
def setup

0 commit comments

Comments
 (0)