coding style: use C++11 for-each construct

... instead of BOOST_FOREACH(...)

Closes: https://github.com/kdudka/csdiff/pull/15

Author: kdudka

src/abstract-filter.cc

@@ -27,7 +27,6 @@
 #include <vector>
 
 #include <boost/algorithm/string/replace.hpp>
-#include <boost/foreach.hpp>
 
 // /////////////////////////////////////////////////////////////////////////////
 // implementation of PredicateFilter
@@ -51,7 +50,7 @@ PredicateFilter::PredicateFilter(AbstractWriter *slave):
 
 PredicateFilter::~PredicateFilter()
 {
-    BOOST_FOREACH(IPredicate *pred, d->preds_)
+    for (IPredicate *pred : d->preds_)
         delete pred;
 
     delete d;
@@ -71,7 +70,7 @@ bool PredicateFilter::matchDef(const Defect &def)
 {
     const bool neg = d->invertEach_;
 
-    BOOST_FOREACH(const IPredicate *pred, d->preds_) {
+    for (const IPredicate *pred : d->preds_) {
         if (neg == pred->matchDef(def))
             return false;
     }
@@ -110,7 +109,7 @@ void dropCtxLines(TEvtList *pEvtList)
     static CtxEventDetector detector;
 
     TEvtList dst;
-    BOOST_FOREACH(const DefEvent &evt, *pEvtList) {
+    for (const DefEvent &evt : *pEvtList) {
         if (detector.isAnyCtxLine(evt))
             continue;
 

src/abstract-parser.cc

@@ -23,8 +23,6 @@
 #include "gcc-parser.hh"
 #include "json-parser.hh"
 
-#include <boost/foreach.hpp>
-
 AbstractParser* createParser(
         std::istream        &input,
         const std::string   &fileName,

src/csdiff-core.cc

@@ -23,14 +23,13 @@
 #include "deflookup.hh"
 #include "json-writer.hh"
 
-#include <boost/foreach.hpp>
 #include <boost/shared_ptr.hpp>
 
 // FIXME: some keys should be merge more intelligently if they already exist
 // TODO: define a nesting limit for keys like diffbase-diffbase-diffbase-...
 void mergeScanProps(TScanProps &props, const TScanProps &oldProps)
 {
-    BOOST_FOREACH(TScanProps::const_reference item, oldProps) {
+    for (TScanProps::const_reference item : oldProps) {
         const std::string &oldKey = item.first;
         const std::string &oldVal = item.second;
         std::string key("diffbase-");

src/csdiff.cc

@@ -24,7 +24,6 @@
 
 #include <cstdlib>
 
-#include <boost/foreach.hpp>
 #include <boost/program_options.hpp>
 #include <boost/regex.hpp>
 
@@ -121,7 +120,7 @@ int main(int argc, char *argv[])
         const TStringList &substList = vm["file-rename"].as<TStringList>();
         boost::smatch sm;
         const boost::regex reSubst("([^,]+),(.*)");
-        BOOST_FOREACH(const string &subst, substList) {
+        for (const string &subst : substList) {
             if (!boost::regex_match(subst, sm, reSubst)) {
                 std::cerr << "bad substutution format: " << subst
                     << std::endl << "use: -s OLD,NEW" << std::endl;

src/csfilter.cc

@@ -22,7 +22,6 @@
 #include <iostream>
 
 #include <boost/regex.hpp>
-#include <boost/foreach.hpp>
 
 // Setup verbosity for debugging string substitions while matching them.
 // Verbosity levels are from 0 to 3 (0 is off)
@@ -118,7 +117,7 @@ struct MsgFilter::Private {
             "PROSPECTOR_WARNING",
             "PYLINT_WARNING"
         };
-        BOOST_FOREACH(const std::string &checker, pylintCheckers) {
+        for (const std::string &checker : pylintCheckers) {
             // "Too many lines in module (1152/1000)" etc.
             addMsgFilter(checker, " \\([0-9]+/[0-9]+\\)$", "");
 
@@ -144,8 +143,8 @@ MsgFilter::MsgFilter():
 
 MsgFilter::~MsgFilter()
 {
-    BOOST_FOREACH(TMsgFilterMap::const_reference item, d->msgFilterMap)
-        BOOST_FOREACH(struct MsgReplace *rpl, item.second)
+    for (TMsgFilterMap::const_reference item : d->msgFilterMap)
+        for (struct MsgReplace *rpl : item.second)
             delete rpl;
 
     delete d;
@@ -168,12 +167,12 @@ std::string MsgFilter::filterMsg(
         const std::string &checker)
 {
     std::string filtered = msg;
-    BOOST_FOREACH(const struct MsgReplace *rpl, d->msgFilterMap[checker]) {
+    for (const struct MsgReplace *rpl : d->msgFilterMap[checker]) {
         filtered = regexReplaceWrap(filtered, rpl->regex, rpl->replaceWith);
     }
 
     // these substitutions are common for all checkers
-    BOOST_FOREACH(const struct MsgReplace *rpl, d->msgFilterMap[""]) {
+    for (const struct MsgReplace *rpl : d->msgFilterMap[""]) {
         filtered = regexReplaceWrap(filtered, rpl->regex, rpl->replaceWith);
     }
 

src/csgrep.cc

@@ -28,7 +28,6 @@
 #include <iomanip>
 #include <map>
 
-#include <boost/foreach.hpp>
 #include <boost/program_options.hpp>
 #include <boost/regex.hpp>
 
@@ -95,7 +94,7 @@ class DefCounter: public StatWriter {
         }
 
         virtual void flush() {
-            BOOST_FOREACH(TMap::const_reference item, cnt_) {
+            for (TMap::const_reference item : cnt_) {
                 using namespace std;
                 const ios_base::fmtflags oldFlags = cout.flags();
                 const int oldWidth = cout.width();
@@ -121,7 +120,7 @@ class EvtCounter: public StatWriter {
         }
 
         virtual void flush() {
-            BOOST_FOREACH(TMap::const_reference item, cnt_) {
+            for (TMap::const_reference item : cnt_) {
                 using namespace std;
                 const ios_base::fmtflags oldFlags = cout.flags();
                 const int oldWidth = cout.width();
@@ -144,7 +143,7 @@ class FileDefCounter: public StatWriter {
 
     public:
         virtual ~FileDefCounter() {
-            BOOST_FOREACH(TMap::const_reference item, cntMap_)
+            for (TMap::const_reference item : cntMap_)
                 delete /* (DefCounter *) */ item.second;
         }
 
@@ -160,7 +159,7 @@ class FileDefCounter: public StatWriter {
         }
 
         virtual void flush() {
-            BOOST_FOREACH(TMap::const_reference item, cntMap_) {
+            for (TMap::const_reference item : cntMap_) {
                 const std::string fName = item.first;
                 std::cout << "\n\n--- " << fName << " ---\n";
 
@@ -181,7 +180,7 @@ class MsgPredicate: public IPredicate {
         }
 
         virtual bool matchDef(const Defect &def) const {
-            BOOST_FOREACH(const DefEvent &evt, def.events) {
+            for (const DefEvent &evt : def.events) {
                 if (boost::regex_search(evt.msg, re_))
                     return true;
             }
@@ -323,7 +322,7 @@ class PathStripper: public GenericAbstractFilter {
             Defect def(defOrig);
 
             // iterate through all events
-            BOOST_FOREACH(DefEvent &evt, def.events) {
+            for (DefEvent &evt : def.events) {
                 std::string &path = evt.fileName;
                 if (path.size() < prefSize_)
                     continue;
@@ -638,7 +637,7 @@ int main(int argc, char *argv[])
     }
     else {
         const TStringList &files = vm["input-file"].as<TStringList>();
-        BOOST_FOREACH(const string &fileName, files) {
+        for (const string &fileName : files) {
             if (!eng->handleFile(fileName, silent))
                 hasError = true;
         }

src/cslinker.cc

@@ -67,7 +67,7 @@ bool loadPropsFromIniFile(
 
         // update scan properties from the ptree node
         pt::ptree scanNode = root.get_child("scan");
-        BOOST_FOREACH(const pt::ptree::value_type &item, scanNode)
+        for (const pt::ptree::value_type &item : scanNode)
             props[item.first] = item.second.data();
 
         // write the updated scan properties back to the writer

src/cssort.cc

@@ -20,7 +20,6 @@
 #include "abstract-writer.hh"
 #include "version.hh"
 
-#include <boost/foreach.hpp>
 #include <boost/program_options.hpp>
 #include <boost/regex.hpp>
 
@@ -53,7 +52,7 @@ class GenericSort: public AbstractWriter {
                 createWriter(std::cout, this->inputFormat(), cm_, scanProps_);
 
             // write the data
-            BOOST_FOREACH(const Defect &def, cont_)
+            for (const Defect &def : cont_)
                 writer->handleDef(def);
 
             // flush data and destroy writer
@@ -238,7 +237,7 @@ int main(int argc, char *argv[])
     }
     else {
         const TStringList &files = vm["input-file"].as<TStringList>();
-        BOOST_FOREACH(const string &fileName, files) {
+        for (const string &fileName : files) {
             if (!eng->handleFile(fileName, silent))
                 hasError = true;
         }

src/cstrans-df-run.cc

@@ -21,7 +21,6 @@
 
 #include <boost/algorithm/string/replace.hpp>
 #include <boost/filesystem.hpp>
-#include <boost/foreach.hpp>
 #include <boost/program_options.hpp>
 #include <boost/regex.hpp>
 #include <boost/tokenizer.hpp>
@@ -75,7 +74,7 @@ void appendExecArgs(TStringList *pExecList, const std::string &str)
     std::string arg;
 
     // process the given string char by char
-    BOOST_FOREACH(const unsigned char c, str) {
+    for (const unsigned char c : str) {
         switch (state) {
             case ES_SEEK_QUOT_OPEN:
                 if ('\"' == c)
@@ -150,7 +149,7 @@ std::string runLineFromExecList(const TStringList &execList)
     // construct RUN ["cmd", "arg1", "arg2", ...] from execList
     std::string runLine = "RUN [";
     int i = 0;
-    BOOST_FOREACH (const std::string &arg, execList) {
+    for (const std::string &arg : execList) {
         if (i++)
             runLine += ", ";
 

src/cswriter.cc

@@ -19,8 +19,6 @@
 
 #include "cswriter.hh"
 
-#include <boost/foreach.hpp>
-
 struct CovWriter::Private {
     std::ostream       &str;
     ColorWriter         cw;
@@ -62,7 +60,7 @@ void CovWriter::handleDef(const Defect &def)
         str << def.annotation;
     str << d->cw.setColor(C_NO_COLOR) << ":\n";
 
-    BOOST_FOREACH(const DefEvent &evt, def.events) {
+    for (const DefEvent &evt : def.events) {
         const bool isKeyEvt = !evt.verbosityLevel;
         if (!isKeyEvt)
             str << d->cw.setColor(C_DARK_GRAY);