parser-cov: look for an explicitly defined key event

... in forward direction, which seems to be more compatible
with Coverity's native assignment of key events.

Related: https://issues.redhat.com/browse/OSH-552

Author: kdudka

src/lib/parser-cov.cc

@@ -366,7 +366,8 @@ bool KeyEventDigger::guessKeyEvent(Defect *def)
         // use the corresponding set of events from d->hMap
         pKeyEvents = &it->second;
 
-    for (int idx = evtCount - 1U; idx >= 0; --idx) {
+    // look for an explicitly defined key event
+    for (unsigned idx = 0U; idx < evtCount; ++idx) {
         const DefEvent &evt = evtList[idx];
         const std::string evtName = d->stripEvtName(evt.event);
         if (!pKeyEvents->count(evtName))

tests/csdiff/diff7.0-icu/00-add-z.err

@@ -522,11 +522,6 @@ Error: DEADCODE:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xqf.c:161: cannot_set: After this line (or expression), the value of "old_val" cannot be any of { 0 1 }.
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xqf.c:164: dead_error_line: Execution cannot reach this expression "0" inside statement "n[0] = box_num((old_val ? 1...".
 
-Error: FORWARD_NULL:
-/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/page.c:1562: var_compare_op: Comparing "pf->pf_org" to null implies that "pf->pf_org" might be null.
-/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/page.c:1566: var_deref_model: Passing null variable "pf->pf_org" to function "pg_move_cursors", which dereferences it.
-/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/insert.c:431: deref_parm: Directly dereferencing parameter "buf_from".
-
 Error: FORWARD_NULL:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/sparql_core.c:3748: var_compare_op: Comparing "parent" to null implies that "parent" might be null.
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/sparql_core.c:3751: var_deref_op: Dereferencing null variable "parent".
@@ -561,10 +556,6 @@ Error: FORWARD_NULL:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/bif_imap.c:210: var_compare_op: Comparing "a" to null implies that "a" might be null.
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/bif_imap.c:213: var_deref_op: Dereferencing null variable "a".
 
-Error: FORWARD_NULL:
-/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/http.c:3359: var_compare_op: Comparing "ws->ws_req_line" to null implies that "ws->ws_req_line" might be null.
-/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/http.c:3525: var_deref_model: Passing null variable "ws->ws_req_line" to function "strchr", which dereferences it. (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
-
 Error: FORWARD_NULL:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/nquad_p.y:303: assign_zero: Assigning: "ttlp_arg->ttlp_last_complete_uri" = 0.
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/nquad_p.y:325: var_deref_model: Passing null variable "ttlp_arg->ttlp_last_complete_uri" to function "strcmp", which dereferences it. (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
@@ -2059,6 +2050,14 @@ Error: UNINIT:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/binsrc/tests/virtdriver.c:189: uninit_use_in_call: Using uninitialized value "ta.ta_is_on" when calling "ta_init".
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/binsrc/tests/time.c:55: read_parm_fld: Reading a parameter field.
 
+Error: UNINIT:
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xslt.c:734: var_decl: Declaring variable "val" without initializer.
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xslt.c:809: uninit_use: Using uninitialized value "*val".
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xslt.c:809: uninit_use: Using uninitialized value "val".
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xslt.c:811: uninit_use_in_call: Using uninitialized value "val" when calling "box_hash".
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Dk/Dkhashext.c:298: read_parm: Reading a parameter value.
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xslt.c:818: uninit_use: Using uninitialized value "val".
+
 Error: UNREACHABLE:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/sqlbif.c:9370: unreachable: This code cannot be reached: "goto cvt_error;".
 

tests/csdiff/diff7.0-icu/00-add.err

@@ -522,11 +522,6 @@ Error: DEADCODE:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xqf.c:161: cannot_set: After this line (or expression), the value of "old_val" cannot be any of { 0 1 }.
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xqf.c:164: dead_error_line: Execution cannot reach this expression "0" inside statement "n[0] = box_num((old_val ? 1...".
 
-Error: FORWARD_NULL:
-/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/page.c:1562: var_compare_op: Comparing "pf->pf_org" to null implies that "pf->pf_org" might be null.
-/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/page.c:1566: var_deref_model: Passing null variable "pf->pf_org" to function "pg_move_cursors", which dereferences it.
-/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/insert.c:431: deref_parm: Directly dereferencing parameter "buf_from".
-
 Error: FORWARD_NULL:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/sparql_core.c:3748: var_compare_op: Comparing "parent" to null implies that "parent" might be null.
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/sparql_core.c:3751: var_deref_op: Dereferencing null variable "parent".
@@ -561,10 +556,6 @@ Error: FORWARD_NULL:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/bif_imap.c:210: var_compare_op: Comparing "a" to null implies that "a" might be null.
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/bif_imap.c:213: var_deref_op: Dereferencing null variable "a".
 
-Error: FORWARD_NULL:
-/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/http.c:3359: var_compare_op: Comparing "ws->ws_req_line" to null implies that "ws->ws_req_line" might be null.
-/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/http.c:3525: var_deref_model: Passing null variable "ws->ws_req_line" to function "strchr", which dereferences it. (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
-
 Error: FORWARD_NULL:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/nquad_p.y:303: assign_zero: Assigning: "ttlp_arg->ttlp_last_complete_uri" = 0.
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/nquad_p.y:325: var_deref_model: Passing null variable "ttlp_arg->ttlp_last_complete_uri" to function "strcmp", which dereferences it. (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
@@ -2059,6 +2050,14 @@ Error: UNINIT:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/binsrc/tests/virtdriver.c:189: uninit_use_in_call: Using uninitialized value "ta.ta_is_on" when calling "ta_init".
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/binsrc/tests/time.c:55: read_parm_fld: Reading a parameter field.
 
+Error: UNINIT:
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xslt.c:734: var_decl: Declaring variable "val" without initializer.
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xslt.c:809: uninit_use: Using uninitialized value "*val".
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xslt.c:809: uninit_use: Using uninitialized value "val".
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xslt.c:811: uninit_use_in_call: Using uninitialized value "val" when calling "box_hash".
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Dk/Dkhashext.c:298: read_parm: Reading a parameter value.
+/builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/xslt.c:818: uninit_use: Using uninitialized value "val".
+
 Error: UNREACHABLE:
 /builddir/build/BUILD/virtuoso-opensource-6.1.3/libsrc/Wi/sqlbif.c:9370: unreachable: This code cannot be reached: "goto cvt_error;".
 

tests/csdiff/diff7.0-icu/00-fix-z.err

@@ -127,11 +127,6 @@ virtuoso-opensource-6.1.2/libsrc/Wi/bif_date.c:148: const: After this line, the
 virtuoso-opensource-6.1.2/libsrc/Wi/bif_date.c:148: assignment: Assigning: "ymd_found" = "1".
 virtuoso-opensource-6.1.2/libsrc/Wi/bif_date.c:252: dead_error_begin: Execution cannot reach this statement "err_msg_ret[0] = "Datetime ...".
 
-Error: FORWARD_NULL:
-virtuoso-opensource-6.1.2/libsrc/Wi/blob.c:1706: var_compare_op: Comparing "migr_buf" to null implies that "migr_buf" might be null.
-virtuoso-opensource-6.1.2/libsrc/Wi/blob.c:1721: var_deref_model: Passing null variable "migr_buf" to function "page_leave_inner", which dereferences it.
-virtuoso-opensource-6.1.2/libsrc/Wi/gate.c:424: deref_parm: Directly dereferencing parameter "buf".
-
 Error: FORWARD_NULL:
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_tree.c:3224: assign_zero: Assigning: "esub_res" = 0.
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_tree.c:3272: var_deref_op: Dereferencing null variable "esub_res".
@@ -159,13 +154,6 @@ virtuoso-opensource-6.1.2/libsrc/Wi/map_schema.c:418: var_compare_op: Comparing
 virtuoso-opensource-6.1.2/libsrc/Wi/map_schema.c:439: var_deref_model: Passing null variable "(caddr_t)attr_component->cm_type.spec.attribute.ann.sql_field" to function "box_dv_uname_string", which dereferences it.
 virtuoso-opensource-6.1.2/libsrc/Dk/Dkbox.c:2125: deref_parm_in_call: Function "strlen" dereferences parameter "string". (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
 
-Error: FORWARD_NULL:
-virtuoso-opensource-6.1.2/libsrc/Wi/http.c:3266: var_compare_op: Comparing "ws->ws_req_line" to null implies that "ws->ws_req_line" might be null.
-virtuoso-opensource-6.1.2/libsrc/Wi/http.c:3432: var_deref_model: Passing null variable "ws->ws_req_line" to function "strchr", which dereferences it. (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
-virtuoso-opensource-6.1.2/libsrc/Wi/http.c:3443: var_deref_model: Passing null variable "ws->ws_req_line" to function "ws_dav", which dereferences it.
-virtuoso-opensource-6.1.2/libsrc/Wi/bif_dav.c:304: deref_parm_in_call: Function "ws_dav_put" dereferences parameter "ws->ws_req_line".
-virtuoso-opensource-6.1.2/libsrc/Wi/bif_dav.c:168: deref_parm_in_call: Function "strchr" dereferences parameter "ws->ws_req_line". (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
-
 Error: FORWARD_NULL:
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_tree.c:3896: var_compare_op: Comparing "tree" to null implies that "tree" might be null.
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_tree.c:4269: alias_transfer: Assigning null: "n" = "tree".
@@ -1494,6 +1482,10 @@ virtuoso-opensource-6.1.2/libsrc/Wi/sparql_core.c:3858: var_decl: Declaring vari
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_core.c:3906: uninit_use_in_call: Using uninitialized value "sqlvals[0]" when calling "spar_make_literal_from_sql_box".
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_core.c:3796: read_parm: Reading a parameter value.
 
+Error: UNINIT:
+virtuoso-opensource-6.1.2/libsrc/Wi/xslt.c:669: var_decl: Declaring variable "val" without initializer.
+virtuoso-opensource-6.1.2/libsrc/Wi/xslt.c:726: uninit_use: Using uninitialized value "val".
+
 Error: UNREACHABLE:
 virtuoso-opensource-6.1.2/libsrc/Wi/ddlrun.c:5312: unreachable: This code cannot be reached: "dk_free_box(r_text);".
 

tests/csdiff/diff7.0-icu/00-fix.err

@@ -127,11 +127,6 @@ virtuoso-opensource-6.1.2/libsrc/Wi/bif_date.c:148: const: After this line, the
 virtuoso-opensource-6.1.2/libsrc/Wi/bif_date.c:148: assignment: Assigning: "ymd_found" = "1".
 virtuoso-opensource-6.1.2/libsrc/Wi/bif_date.c:252: dead_error_begin: Execution cannot reach this statement "err_msg_ret[0] = "Datetime ...".
 
-Error: FORWARD_NULL:
-virtuoso-opensource-6.1.2/libsrc/Wi/blob.c:1706: var_compare_op: Comparing "migr_buf" to null implies that "migr_buf" might be null.
-virtuoso-opensource-6.1.2/libsrc/Wi/blob.c:1721: var_deref_model: Passing null variable "migr_buf" to function "page_leave_inner", which dereferences it.
-virtuoso-opensource-6.1.2/libsrc/Wi/gate.c:424: deref_parm: Directly dereferencing parameter "buf".
-
 Error: FORWARD_NULL:
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_tree.c:3224: assign_zero: Assigning: "esub_res" = 0.
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_tree.c:3272: var_deref_op: Dereferencing null variable "esub_res".
@@ -159,13 +154,6 @@ virtuoso-opensource-6.1.2/libsrc/Wi/map_schema.c:418: var_compare_op: Comparing
 virtuoso-opensource-6.1.2/libsrc/Wi/map_schema.c:439: var_deref_model: Passing null variable "(caddr_t)attr_component->cm_type.spec.attribute.ann.sql_field" to function "box_dv_uname_string", which dereferences it.
 virtuoso-opensource-6.1.2/libsrc/Dk/Dkbox.c:2125: deref_parm_in_call: Function "strlen" dereferences parameter "string". (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
 
-Error: FORWARD_NULL:
-virtuoso-opensource-6.1.2/libsrc/Wi/http.c:3266: var_compare_op: Comparing "ws->ws_req_line" to null implies that "ws->ws_req_line" might be null.
-virtuoso-opensource-6.1.2/libsrc/Wi/http.c:3432: var_deref_model: Passing null variable "ws->ws_req_line" to function "strchr", which dereferences it. (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
-virtuoso-opensource-6.1.2/libsrc/Wi/http.c:3443: var_deref_model: Passing null variable "ws->ws_req_line" to function "ws_dav", which dereferences it.
-virtuoso-opensource-6.1.2/libsrc/Wi/bif_dav.c:304: deref_parm_in_call: Function "ws_dav_put" dereferences parameter "ws->ws_req_line".
-virtuoso-opensource-6.1.2/libsrc/Wi/bif_dav.c:168: deref_parm_in_call: Function "strchr" dereferences parameter "ws->ws_req_line". (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
-
 Error: FORWARD_NULL:
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_tree.c:3896: var_compare_op: Comparing "tree" to null implies that "tree" might be null.
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_tree.c:4269: alias_transfer: Assigning null: "n" = "tree".
@@ -1494,6 +1482,10 @@ virtuoso-opensource-6.1.2/libsrc/Wi/sparql_core.c:3858: var_decl: Declaring vari
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_core.c:3906: uninit_use_in_call: Using uninitialized value "sqlvals[0]" when calling "spar_make_literal_from_sql_box".
 virtuoso-opensource-6.1.2/libsrc/Wi/sparql_core.c:3796: read_parm: Reading a parameter value.
 
+Error: UNINIT:
+virtuoso-opensource-6.1.2/libsrc/Wi/xslt.c:669: var_decl: Declaring variable "val" without initializer.
+virtuoso-opensource-6.1.2/libsrc/Wi/xslt.c:726: uninit_use: Using uninitialized value "val".
+
 Error: UNREACHABLE:
 virtuoso-opensource-6.1.2/libsrc/Wi/ddlrun.c:5312: unreachable: This code cannot be reached: "dk_free_box(r_text);".
 

tests/csdiff/diff7.0-virtuoso-opensource/00-add-z.err

@@ -187,7 +187,7 @@
             "checker": "UNINIT",
             "cwe": 457,
             "tool": "coverity",
-            "key_event_idx": 6,
+            "key_event_idx": 4,
             "events": [
                 {
                     "file_name": "",
@@ -222,7 +222,7 @@
                     "line": 6528,
                     "event": "uninit_use_in_call",
                     "message": "Using uninitialized value \"checkPoint.nextMulti\" when calling \"MultiXactSetNextMXact(MultiXactId, MultiXactOffset)\".",
-                    "verbosity_level": 1
+                    "verbosity_level": 0
                 },
                 {
                     "file_name": "postgresql-9.2.4/src/backend/access/transam/multixact.c",
@@ -237,7 +237,7 @@
                     "line": 6528,
                     "event": "uninit_use_in_call",
                     "message": "Using uninitialized value \"checkPoint.nextMultiOffset\" when calling \"MultiXactSetNextMXact(MultiXactId, MultiXactOffset)\".",
-                    "verbosity_level": 0
+                    "verbosity_level": 1
                 },
                 {
                     "file_name": "postgresql-9.2.4/src/backend/access/transam/multixact.c",
@@ -398,7 +398,7 @@
             "checker": "UNINIT",
             "cwe": 457,
             "tool": "coverity",
-            "key_event_idx": 4,
+            "key_event_idx": 2,
             "events": [
                 {
                     "file_name": "",
@@ -419,7 +419,7 @@
                     "line": 6529,
                     "event": "uninit_use_in_call",
                     "message": "Using uninitialized value \"checkPoint.oldestXid\" when calling \"SetTransactionIdLimit(TransactionId, Oid)\".",
-                    "verbosity_level": 1
+                    "verbosity_level": 0
                 },
                 {
                     "file_name": "postgresql-9.2.4/src/backend/access/transam/varsup.c",
@@ -434,7 +434,7 @@
                     "line": 6529,
                     "event": "uninit_use_in_call",
                     "message": "Using uninitialized value \"checkPoint.oldestXidDB\" when calling \"SetTransactionIdLimit(TransactionId, Oid)\".",
-                    "verbosity_level": 0
+                    "verbosity_level": 1
                 },
                 {
                     "file_name": "postgresql-9.2.4/src/backend/access/transam/varsup.c",

tests/csdiff/diff7.0-virtuoso-opensource/00-add.err

@@ -4075,6 +4075,13 @@ Error: UNINIT:
 /builddir/build/BUILD/ATLAS/interfaces/lapack/C/src/clapack_ztrtri.c:41: var_decl: Declaring variable "ierr" without initializer.
 /builddir/build/BUILD/ATLAS/interfaces/lapack/C/src/clapack_ztrtri.c:75: uninit_use: Using uninitialized value "ierr".
 
+Error: UNINIT:
+/builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:38: var_decl: Declaring variable "h11" without initializer.
+/builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:106: uninit_use: Using uninitialized value "h11".
+/builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:120: uninit_use: Using uninitialized value "h11".
+/builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:186: uninit_use: Using uninitialized value "h11".
+/builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:188: uninit_use: Using uninitialized value "h11".
+
 Error: UNINIT:
 /builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:38: var_decl: Declaring variable "h12" without initializer.
 /builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:107: uninit_use: Using uninitialized value "h12".
@@ -4091,13 +4098,6 @@ Error: UNINIT:
 /builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:186: uninit_use: Using uninitialized value "h21".
 /builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:187: uninit_use: Using uninitialized value "h21".
 
-Error: UNINIT:
-/builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:38: var_decl: Declaring variable "h11" without initializer.
-/builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:106: uninit_use: Using uninitialized value "h11".
-/builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:120: uninit_use: Using uninitialized value "h11".
-/builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:186: uninit_use: Using uninitialized value "h11".
-/builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:188: uninit_use: Using uninitialized value "h11".
-
 Error: UNINIT:
 /builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:38: var_decl: Declaring variable "h22" without initializer.
 /builddir/build/BUILD/ATLAS/src/blas/level1/ATL_rotmg.c:139: uninit_use: Using uninitialized value "h22".