Skip to content

Commit 412ca86

Browse files
kdudkakdudka
committed
csparser: blacklist example_{assign,checked} for key events
1 parent 191128a commit 412ca86

File tree

5 files changed

+50
-0
lines changed

5 files changed

+50
-0
lines changed

‎csparser.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,8 @@ KeyEventDigger::KeyEventDigger():
272272
d->blackList.insert("another_instance");
273273
d->blackList.insert("comparison_remediation");
274274
d->blackList.insert("example_access");
275+
d->blackList.insert("example_assign");
276+
d->blackList.insert("example_checked");
275277
d->blackList.insert("example_comparison");
276278
d->blackList.insert("example_lock");
277279
d->blackList.insert("function_annotation");

‎tests/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ test_csgrep(csgrep "43-gcc-parser-smatch" )
153153
test_csgrep(csgrep "44-csparser-new-key-evts" )
154154
test_csgrep(csgrep "45-gcc-parser-clang" )
155155
test_csgrep(csgrep "46-cov-json-v2" )
156+
test_csgrep(csgrep "47-csparser-new-key-evts" )
156157
test_csparser(csparser-5.8 00)
157158
test_csparser(csparser-5.8 01)
158159
test_csparser(csparser-5.8 02)

‎tests/csgrep/47-csparser-new-key-evts-args.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
--prune-events=0

‎tests/csgrep/47-csparser-new-key-evts-stdin.txt

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
Error: NULL_RETURNS:
2+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-connection.c:637: returned_null: "_dbus_list_get_last_link" returns null (checked 7 out of 8 times).
3+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-connection.c:637: var_assigned: Assigning: "link" = null return value from "_dbus_list_get_last_link".
4+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-connection.c:641: dereference: Dereferencing a pointer that might be null "link" when calling "_dbus_list_unlink".
5+
/builddir/build/BUILD/dbus-1.10.24/bus/bus.c:549: example_assign: Example 1: Assigning: "link" = return value from "_dbus_list_get_last_link(&context->servers)".
6+
/builddir/build/BUILD/dbus-1.10.24/bus/bus.c:550: example_checked: Example 1 (cont.): "link" has its value checked in "link != NULL".
7+
/builddir/build/BUILD/dbus-1.10.24/bus/connection.c:2505: example_assign: Example 2: Assigning: "link" = return value from "_dbus_list_get_last_link(&d->transaction_messages)".
8+
/builddir/build/BUILD/dbus-1.10.24/bus/connection.c:2506: example_checked: Example 2 (cont.): "link" has its value checked in "link != NULL".
9+
/builddir/build/BUILD/dbus-1.10.24/bus/signals.c:1631: example_assign: Example 3: Assigning: "link" = return value from "_dbus_list_get_last_link(rules)".
10+
/builddir/build/BUILD/dbus-1.10.24/bus/signals.c:1632: example_checked: Example 3 (cont.): "link" has its value checked in "link != NULL".
11+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-connection.c:4217: example_checked: Example 4: "_dbus_list_get_last_link(&connection->outgoing_messages)" has its value checked in "link = _dbus_list_get_last_link(&connection->outgoing_messages)".
12+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-list.c:477: example_assign: Example 5: Assigning: "link" = return value from "_dbus_list_get_last_link(list)".
13+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-list.c:479: example_checked: Example 5 (cont.): "link" has its value checked in "link != NULL".
14+
15+
Error: NULL_RETURNS:
16+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-connection.c:3981: path: Condition "connection->n_incoming > 0", taking true branch.
17+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-connection.c:3985: returned_null: "_dbus_list_pop_first_link" returns null (checked 10 out of 12 times).
18+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-connection.c:3985: var_assigned: Assigning: "link" = null return value from "_dbus_list_pop_first_link".
19+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-connection.c:4007: dereference: Dereferencing a null pointer "link".
20+
/builddir/build/BUILD/dbus-1.10.24/bus/config-parser-trivial.c:183: example_checked: Example 1: "_dbus_list_pop_first_link(&dirs)" has its value checked in "link = _dbus_list_pop_first_link(&dirs)".
21+
/builddir/build/BUILD/dbus-1.10.24/bus/config-parser.c:348: example_checked: Example 2: "_dbus_list_pop_first_link(&included->conf_dirs)" has its value checked in "link = _dbus_list_pop_first_link(&included->conf_dirs)".
22+
/builddir/build/BUILD/dbus-1.10.24/bus/config-parser.c:854: example_checked: Example 3: "_dbus_list_pop_first_link(&dirs)" has its value checked in "link = _dbus_list_pop_first_link(&dirs)".
23+
/builddir/build/BUILD/dbus-1.10.24/bus/config-parser.c:880: example_checked: Example 4: "_dbus_list_pop_first_link(&dirs)" has its value checked in "link = _dbus_list_pop_first_link(&dirs)".
24+
/builddir/build/BUILD/dbus-1.10.24/bus/policy.c:624: example_checked: Example 5: "_dbus_list_pop_first_link(&tmp_list)" has its value checked in "link = _dbus_list_pop_first_link(&tmp_list)".
25+
26+
Error: NULL_RETURNS:
27+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:245: path: Condition "watches == NULL", taking true branch.
28+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:246: returned_null: "_dbus_hash_table_lookup_pollable" returns null (checked 4 out of 5 times).
29+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:246: var_assigned: Assigning: "watches" = null return value from "_dbus_hash_table_lookup_pollable".
30+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:252: dereference: Dereferencing a pointer that might be null "watches" when calling "_dbus_list_get_first_link".
31+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:176: example_assign: Example 1: Assigning: "watches" = return value from "_dbus_hash_table_lookup_pollable(loop->watches, fd)".
32+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:178: example_checked: Example 1 (cont.): "watches" has its value checked in "watches == NULL".
33+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:335: example_assign: Example 2: Assigning: "watches" = return value from "_dbus_hash_table_lookup_pollable(loop->watches, fd)".
34+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:337: example_checked: Example 2 (cont.): "watches" has its value checked in "watches != NULL".
35+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:204: example_assign: Example 3: Assigning: "watches" = return value from "_dbus_hash_table_lookup_pollable(loop->watches, fd)".
36+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:206: example_checked: Example 3 (cont.): "watches" has its value checked in "watches != NULL".
37+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:799: example_assign: Example 4: Assigning: "watches" = return value from "_dbus_hash_table_lookup_pollable(loop->watches, ready_fds[i].fd)".
38+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:802: example_checked: Example 4 (cont.): "watches" has its value checked in "watches == NULL".

‎tests/csgrep/47-csparser-new-key-evts-stdout.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
Error: NULL_RETURNS:
2+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-connection.c:641: dereference: Dereferencing a pointer that might be null "link" when calling "_dbus_list_unlink".
3+
4+
Error: NULL_RETURNS:
5+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-connection.c:4007: dereference: Dereferencing a null pointer "link".
6+
7+
Error: NULL_RETURNS:
8+
/builddir/build/BUILD/dbus-1.10.24/dbus/dbus-mainloop.c:252: dereference: Dereferencing a pointer that might be null "watches" when calling "_dbus_list_get_first_link".

0 commit comments

Comments
 (0)