Skip to content

Commit 00d801d

Browse files
committed
coding style: use denyList rather than blackList
The former is known to be politically safer. Closes: https://github.com/kdudka/csdiff/pull/15
1 parent 26df3de commit 00d801d

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

src/csparser.cc

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ struct KeyEventDigger::Private {
201201
typedef std::set<std::string> TSet;
202202
typedef std::map<std::string, TSet> TMap;
203203
TMap hMap;
204-
TSet blackList, traceEvts;
204+
TSet denyList, traceEvts;
205205
const RE reEvtSuffix = RE("^(.*)\\[[^ \\]]+\\]$");
206206
const std::string stripEvtName(const std::string &) const;
207207
};
@@ -275,19 +275,19 @@ KeyEventDigger::KeyEventDigger():
275275
d->hMap["GCC_ANALYZER_WARNING"] .insert("fatal error");
276276

277277
// events that should never be used as key events (excluding trace events)
278-
d->blackList.insert("another_instance");
279-
d->blackList.insert("comparison_remediation");
280-
d->blackList.insert("example_access");
281-
d->blackList.insert("example_assign");
282-
d->blackList.insert("example_checked");
283-
d->blackList.insert("example_comparison");
284-
d->blackList.insert("example_lock");
285-
d->blackList.insert("function_annotation");
286-
d->blackList.insert("included_from");
287-
d->blackList.insert("note");
288-
d->blackList.insert("remediation");
289-
d->blackList.insert("rounding_remediation");
290-
d->blackList.insert("scope_hint");
278+
d->denyList.insert("another_instance");
279+
d->denyList.insert("comparison_remediation");
280+
d->denyList.insert("example_access");
281+
d->denyList.insert("example_assign");
282+
d->denyList.insert("example_checked");
283+
d->denyList.insert("example_comparison");
284+
d->denyList.insert("example_lock");
285+
d->denyList.insert("function_annotation");
286+
d->denyList.insert("included_from");
287+
d->denyList.insert("note");
288+
d->denyList.insert("remediation");
289+
d->denyList.insert("rounding_remediation");
290+
d->denyList.insert("scope_hint");
291291

292292
// trace events
293293
d->traceEvts.insert("break");
@@ -364,7 +364,7 @@ bool KeyEventDigger::guessKeyEvent(Defect *def)
364364
continue;
365365

366366
const std::string &evtName = evt.event;
367-
if (!d->traceEvts.count(evtName) && !d->blackList.count(evtName))
367+
if (!d->traceEvts.count(evtName) && !d->denyList.count(evtName))
368368
// never use trace or black-listed event as the key event
369369
break;
370370
}

0 commit comments

Comments
 (0)