Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead tradeoffs link in FAQ (Write tradeoffs.md) #1483

Open
jeroenhabets opened this issue Mar 29, 2021 · 2 comments
Open

Dead tradeoffs link in FAQ (Write tradeoffs.md) #1483

jeroenhabets opened this issue Mar 29, 2021 · 2 comments
Labels
docs Code is fine, documentation is not. help wanted

Comments

@jeroenhabets
Copy link

Expected behavior:
Clicking "Check out [tradeoffs|https://github.com/cssinjs/jss/blob/master/docs/tradeoffs.md] for more information." opens filled tradeoffs page.

Describe the bug:
Instead I get a 404.

Reproduction:
Navigate to: https://cssinjs.org/faq
Under item "6. Does JSS has overhead?"
Click: "Check out [tradeoffs|https://github.com/cssinjs/jss/blob/master/docs/tradeoffs.md] for more information."

Related to:
Issue New docs #932 "Write tradeoffs.md" from 2018.

(This issue will hopefully prevent others from having to search)

@kof kof added docs Code is fine, documentation is not. help wanted labels Apr 26, 2021
@kof
Copy link
Member

kof commented Apr 26, 2021

We used to have this document, not sure what happened.

@jeroenhabets
Copy link
Author

For what it's worth: I tried to search the git log but couldn't find a tradeoffs.md (or any file with trade):

git log --name-only|grep trade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code is fine, documentation is not. help wanted
Projects
None yet
Development

No branches or pull requests

2 participants