Skip to content

Commit fab9bbd

Browse files
committed
Fix psalm issues
1 parent ee2225f commit fab9bbd

3 files changed

+2
-4
lines changed

src/DocBlockArchitecturalDecision.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ final public function getContents() : string {
1919
$reflection = new \ReflectionClass(static::class);
2020
$content = $reflection->getDocComment();
2121

22-
if (!$content) {
22+
if ($content === false) {
2323
throw MissingDocBlock::fromClass($reflection->getName());
2424
}
2525

src/XmlDocumentGenerator.php

+1-2
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,11 @@ public function generateDocument(string $file, array $scanDirs) : void {
7474
$dom->createElementNS(ArchitecturalDecisionRecord::SCHEMA, 'contents')
7575
);
7676

77-
assert(!is_null($contentsNode->ownerDocument));
7877
$contentsNode->appendChild(
7978
$contentsNode->ownerDocument->createCDATASection($attribute->getContents())
8079
);
8180

82-
if (!empty($decisionAnnotation['targets'])) {
81+
if ($decisionAnnotation['targets'] !== []) {
8382
$codeAnnotationsNode = $decisionElement->appendChild(
8483
$dom->createElementNS(ArchitecturalDecisionRecord::SCHEMA, 'codeAnnotations')
8584
);

tests/Stub/Adr/StubMetaDataArchitecturalDecision.php

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ public function getStatus() : string|DecisionStatus {
2222

2323
public function setMetaData(DOMElement $meta) : void {
2424
$dom = $meta->ownerDocument;
25-
assert(isset($dom));
2625

2726
$foo = $meta->appendChild(
2827
$dom->createElement('foo')

0 commit comments

Comments
 (0)