Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research avoiding multiple alias resolutions for the same abstract service #287

Open
cspray opened this issue Mar 13, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@cspray
Copy link
Owner

cspray commented Mar 13, 2023

It is possible that an abstract service is attempted to have its alias resolved that results in no alias resolutions. We should see if we can skip future checks for similar services since we know the resolution won't succeed. This happens because there are a list of AliasDefinition instances that could list the abstract service multiple times.

@cspray cspray added the enhancement New feature or request label Mar 13, 2023
@cspray cspray added this to the v2.x Release milestone Mar 13, 2023
@cspray cspray self-assigned this Mar 13, 2023
@cspray cspray modified the milestones: v2.x Release, v2.1 Release May 13, 2023
@cspray cspray moved this to Todo in Annotated Container May 13, 2023
@cspray cspray moved this from Todo to In Progress in Annotated Container May 14, 2023
@cspray
Copy link
Owner Author

cspray commented May 14, 2023

This could potentially have some value. We'd be saving iterating over service definitions needlessly during a part of the process that has not been optimized, relative to static analysis where caching drastically increases performance. However, it would involve adding and keeping up with state in the StandardAliasDefinitionResolver. Since this is a fairly low priority item I'm going to wait until, or if, more users could also see value out of doing this.

Will move this into the 2.x milestone.

@cspray cspray modified the milestones: v2.1 Release, v2.x Release May 14, 2023
@cspray cspray moved this from In Progress to Todo in Annotated Container May 14, 2023
@cspray cspray removed this from the v2.x Release milestone May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant