Merge pull request #3 from cspray/bug/add-sources-to-store

Add sources to secrets parameter store

Author: cspray

src/SecretsParameterStoreFactory.php

@@ -25,7 +25,11 @@ public function createParameterStore(string $identifier) : ParameterStore {
             throw InvalidParameterStoreIdentifier::fromIdentifierNotSecretsParameterStore($identifier);
         }
         $store = new SecretsParameterStore();
+        foreach ($this->sources as $source) {
+            $store->addSource($source);
+        }
 
         return $store;
     }
-}
+
+}

tests/SecretsParameterStoreFactoryTest.php

@@ -2,19 +2,24 @@
 
 namespace Cspray\AnnotatedContainer\Secrets\Test;
 
+use Cspray\AnnotatedContainer\Secrets\ArrayValueProvider;
 use Cspray\AnnotatedContainer\Secrets\Exception\InvalidParameterStoreIdentifier;
 use Cspray\AnnotatedContainer\Secrets\Exception\NoSourcesProvided;
 use Cspray\AnnotatedContainer\Secrets\SecretsParameterStore;
 use Cspray\AnnotatedContainer\Secrets\SecretsParameterStoreFactory;
+use Cspray\AnnotatedContainer\Secrets\SingleValueProviderSource;
 use Cspray\AnnotatedContainer\Secrets\Source;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;
+use function Cspray\Typiphy\stringType;
 
 #[
     CoversClass(SecretsParameterStoreFactory::class),
     CoversClass(SecretsParameterStore::class),
     CoversClass(InvalidParameterStoreIdentifier::class),
-    CoversClass(NoSourcesProvided::class)
+    CoversClass(NoSourcesProvided::class),
+    CoversClass(ArrayValueProvider::class),
+    CoversClass(SingleValueProviderSource::class),
 ]
 final class SecretsParameterStoreFactoryTest extends TestCase {
 
@@ -46,4 +51,14 @@ public function testFactoryConstructorGivenNoSourcesThrowsException() : void {
         new SecretsParameterStoreFactory([]);
     }
 
-}
+    public function testSourcesAreProvidedToSecretsParameterStore() : void {
+        $subject = new SecretsParameterStoreFactory(
+            [new SingleValueProviderSource('source', new ArrayValueProvider(['foo' => 'bar']))]
+        );
+
+        $store = $subject->createParameterStore(SecretsParameterStore::class);
+
+        self::assertSame('bar', $store->fetch(stringType(), 'source.foo'));
+    }
+
+}