refactor: add onConflictingLibraryRedirect array to notify all install of request redirect

Author: ejose19

source-map-support.js

@@ -77,7 +77,7 @@ var sharedData = initializeSharedData({
   errorPrepareStackTraceHook: undefined,
   /** @type {HookState} */
   processEmitHook: undefined,
-  /** @type {HookState} */
+  /** @type {HookState & { onConflictingLibraryRedirectArr: Array<(request: string, parent: any, isMain: boolean, redirectedRequest: string) => void> }} */
   moduleResolveFilenameHook: undefined,
 
   // If true, the caches are reset before a stack trace formatting operation
@@ -641,25 +641,36 @@ exports.install = function(options) {
   // Redirect subsequent imports of "source-map-support"
   // to this package
   const {redirectConflictingLibrary = true, onConflictingLibraryRedirect} = options;
-  if(redirectConflictingLibrary && !sharedData.moduleResolveFilenameHook) {
-    const originalValue = Module._resolveFilename;
-    sharedData.moduleResolveFilenameHook = {
-      enabled: true,
-      originalValue,
-      installedValue: undefined
-    }
-    Module._resolveFilename = sharedData.moduleResolveFilenameHook.installedValue = function (request, parent, isMain, options) {
-      // Match all source-map-support entrypoints: source-map-support, source-map-support/register
-      if (request === 'source-map-support') {
-          const newRequest = require.resolve('./');
-          if(onConflictingLibraryRedirect) onConflictingLibraryRedirect(request, parent, isMain, options, newRequest);
-          request = newRequest;
-      } else if (request === 'source-map-support/register') {
-          const newRequest = require.resolve('./register');
-          if(onConflictingLibraryRedirect) onConflictingLibraryRedirect(request, parent, isMain, options, newRequest);
-          request = newRequest;
+  if(redirectConflictingLibrary) {
+    if (!sharedData.moduleResolveFilenameHook) {
+      const originalValue = Module._resolveFilename;
+      sharedData.moduleResolveFilenameHook = {
+        enabled: true,
+        originalValue,
+        installedValue: undefined,
+        onConflictingLibraryRedirectArr: []
+      }
+      Module._resolveFilename = sharedData.moduleResolveFilenameHook.installedValue = function (request, parent, isMain, options) {
+        // Match all source-map-support entrypoints: source-map-support, source-map-support/register
+        let requestRedirect;
+        if (request === 'source-map-support') {
+          requestRedirect = './';
+        } else if (request === 'source-map-support/register') {
+          requestRedirect = './register';
+        }
+
+        if (requestRedirect !== undefined) {
+            const newRequest = require.resolve(requestRedirect);
+            for (const cb of sharedData.moduleResolveFilenameHook.onConflictingLibraryRedirectArr) {
+              cb(request, parent, isMain, options, newRequest);
+            }
+            request = newRequest;
+        }
+        return originalValue.call(this, request, parent, isMain, options);
       }
-      return originalValue.call(this, request, parent, isMain, options);
+    } 
+    if (onConflictingLibraryRedirect) {
+      sharedData.moduleResolveFilenameHook.onConflictingLibraryRedirectArr.push(onConflictingLibraryRedirect);
     }
   }
 

test.js

@@ -730,10 +730,11 @@ describe('redirects require() of "source-map-support" to this module', function(
     assert.strictEqual(onConflictingLibraryRedirectCalls.length, 1);
     assert.strictEqual(onConflictingLibraryRedirectCalls2.length, 1);
     for(const args of [onConflictingLibraryRedirectCalls[0], onConflictingLibraryRedirectCalls2[0]]) {
-      const [request, parent, isMain, redirectedRequest] = args;
+      const [request, parent, isMain, options, redirectedRequest] = args;
       assert.strictEqual(request, 'source-map-support');
       assert.strictEqual(parent, module);
       assert.strictEqual(isMain, false);
+      assert.strictEqual(options, undefined);
       assert.strictEqual(redirectedRequest, require.resolve('.'));
     }
   });