PR feedback

Author: jusdino

backend/compact-connect/lambdas/python/data-events/handlers/encumbrance_events.py

@@ -23,7 +23,7 @@ def _get_license_type_name(compact: str, license_type_abbreviation: str) -> str:
     return LicenseUtility.get_license_type_by_abbreviation(compact, license_type_abbreviation).name
 
 
-def _get_provider_records_and_validate(compact: str, provider_id: str) -> tuple[ProviderUserRecords, ProviderData]:
+def _get_provider_records(compact: str, provider_id: str) -> tuple[ProviderUserRecords, ProviderData]:
     """
     Retrieve and validate provider records for notification processing.
 
@@ -326,7 +326,7 @@ def privilege_encumbrance_notification_listener(message: dict):
         license_type_name = _get_license_type_name(compact, license_type_abbreviation)
 
         # Get provider records to gather notification targets and provider information
-        provider_records, provider_record = _get_provider_records_and_validate(compact, provider_id)
+        provider_records, provider_record = _get_provider_records(compact, provider_id)
 
         # Provider Notification
         _send_provider_notification(
@@ -401,7 +401,7 @@ def privilege_encumbrance_lifting_notification_listener(message: dict):
         license_type_name = _get_license_type_name(compact, license_type_abbreviation)
 
         # Get provider records to gather notification targets and provider information
-        provider_records, provider_record = _get_provider_records_and_validate(compact, provider_id)
+        provider_records, provider_record = _get_provider_records(compact, provider_id)
 
         # Provider Notification
         _send_provider_notification(
@@ -476,7 +476,7 @@ def license_encumbrance_notification_listener(message: dict):
         license_type_name = _get_license_type_name(compact, license_type_abbreviation)
 
         # Get provider records to gather notification targets and provider information
-        provider_records, provider_record = _get_provider_records_and_validate(compact, provider_id)
+        provider_records, provider_record = _get_provider_records(compact, provider_id)
 
         # Provider Notification
         _send_provider_notification(
@@ -551,7 +551,7 @@ def license_encumbrance_lifting_notification_listener(message: dict):
         license_type_name = _get_license_type_name(compact, license_type_abbreviation)
 
         # Get provider records to gather notification targets and provider information
-        provider_records, provider_record = _get_provider_records_and_validate(compact, provider_id)
+        provider_records, provider_record = _get_provider_records(compact, provider_id)
 
         # Provider Notification
         _send_provider_notification(

backend/compact-connect/lambdas/python/data-events/tests/function/test_encumbrance_events.py

@@ -943,7 +943,12 @@ def test_privilege_encumbrance_listener_processes_event_with_registered_provider
     def test_privilege_encumbrance_listener_processes_event_with_unregistered_provider(
         self, mock_provider_email, mock_state_email
     ):
-        """Test that privilege encumbrance listener handles unregistered providers."""
+        """
+        Test that privilege encumbrance listener handles unregistered providers.
+
+        Note: An unregistered provider holding a privilege should not be possible in our system.
+        This test is just stressing the limits of our encumbrance logic, to make sure it handles it gracefully.
+        """
         from cc_common.email_service_client import EncumbranceNotificationTemplateVariables
         from handlers.encumbrance_events import privilege_encumbrance_notification_listener