Fixes from comments,license, CI and README.md

Author: Rasmus Oscar Welander

.github/workflows/ci-tests.yml

@@ -35,4 +35,5 @@ jobs:
 
     - name: Test with pytest
       run: |
-        pytest
+        if [ -f tests/requirements.txt ]; then pip install -r tests/requirements.txt; fi
+        pytest --cov-report term --cov=src tests/

.github/workflows/publish.yml

@@ -0,0 +1,33 @@
+name: Publish To PyPI
+
+on:
+  push:
+    tags:
+       - 'v*'
+  
+jobs:
+  build-publish:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: Set environnment package version from tag
+      run: echo "PACKAGE_VERSION=${GITHUB_REF#refs/*/v}" >> $GITHUB_ENV # extract "1.2.3" from refs/tags/v1.2.3
+      
+    - name: Set up Python 3.12
+      uses: actions/setup-python@v3
+      with:
+        python-version: "3.12"
+      
+    - name: Install dependencies 
+      run: pip install build twine
+
+    - name: Build wheel
+      run: python -m build
+
+    - name: Publish distribution to PyPI
+      env:
+        TWINE_USERNAME: __token__
+        TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }}
+      run: twine upload --repository pypi dist/*

LICENSE

@@ -0,0 +1,290 @@
+# CS3Client
+
+`CS3Client` is a Python client for interacting with the CS3 (Cloud Storage Services for Science) API. It allows users to seamlessly communicate with cloud storage services that support CS3 protocols, enabling file management, data transfer, and other cloud-based operations.
+
+## Table of Contents
+
+- [Features](#features)
+- [Installation](#installation)
+- [Usage](#usage)
+- [Configuration](#configuration)
+- [Examples](#examples)
+- [Documentation](#documentation)
+- [License](#license)
+
+
+## Features
+
+- Simple and easy-to-use API client for CS3 services.
+- Support for common file operations (read, write, delete, rename, ...).
+- Support for common lock operations (set lock, get lock, unlock, ...).
+- Support for common share operations (create share, update share, delete share, ...).
+- Support for common user operations (get user, find users, get user groups, ...).
+- Support for restoring files through checkpoints (restore file version, list checkpoints).
+- Support for applications (open in app, list app providers).
+- Authentication and authorization handling.
+- Cross-platform compatibility.
+- Detailed error handling and logging.
+
+## Installation
+
+To install `cs3client`, you need to have Python 3.7+ installed. You can install the package via `pip`:
+
+```bash
+pip install cs3client
+```
+Alternatively, you can clone this repository and install manually:
+```bash
+git clone [email protected]:cs3org/cs3-python-client.git
+cd cs3-python-client
+pip install -e . 
+export PYTHONPATH="path/to/cs3-python-client/:$PYTHONPATH"
+```
+
+
+## Configuration
+
+`CS3Client` can be configured by passing specific parameters when initializing the client through a ConfigParser instance.
+
+### Parameters:
+
+#### Required
+- `host`
+
+#### Optional (parameter - default)
+- `chunk_size` - 4194384
+- `grpc_timeout` - 10
+- `http_timeout` - 10
+- `tus_enabled` - False
+- `ssl_enabled` - False
+- `ssl_client_cert` - None
+- `ssl_client_key` - None
+- `ssl_ca_cert` - None
+- `auth_client_id` - None
+- `auth_login_type` - "basic"
+- `lock_by_setting_attr` - False
+- `lock_not_impl` - False
+- `lock_expiration` - 1800
+
+#### Example configuration
+```yaml
+[cs3client]
+
+# Required
+host = localhost:19000
+# Optional, defaults to 4194304
+chunk_size = 4194304
+# Optional, defaults to 10
+grpc_timeout = 10
+# Optional, defaults to 10
+http_timeout = 10
+
+# Optional, defaults to True
+tus_enabled = False
+
+# Optional, defaults to True
+ssl_enabled = False
+# Optional, defaults to True
+ssl_verify = False
+# Optional, defaults to an empty string
+ssl_client_cert = test_client_cert
+# Optional, defaults to an empty string
+ssl_client_key  = test_client_key
+# Optional, defaults to an empty string
+ssl_ca_cert =  test_ca_cert
+
+# Optinal, defaults to an empty string
+auth_client_id = einstein
+# Optional, defaults to basic
+auth_login_type = basic
+
+# Optional, defaults to False
+lock_by_setting_attr = False
+# Optional, defaults to False
+lock_not_impl = False
+# Optional, defaults to 1800
+lock_expiration = 1800
+
+
+```
+
+## Usage
+
+To use `cs3client`, you first need to import and configure it. Here's a simple example of how to set up and start using the client. For configuration see [Configuration](#configuration). For more in depth examples see `cs3-python-client/examples/`. 
+
+### Initilization
+```python
+import logging
+import configparser
+from cs3client import CS3Client
+from cs3resource import Resource
+
+config = configparser.ConfigParser()
+with open("default.conf") as fdef:
+    config.read_file(fdef)
+
+log = logging.getLogger(__name__)
+
+client = CS3Client(config, "cs3client", log)
+# client.auth.set_token("<your_token_here>")
+# OR
+client.auth.set_client_secret("<your_client_secret_here>")
+```
+
+### File Example
+```python
+# mkdir
+directory_resource = Resource.from_file_ref_and_endpoint(f"/eos/user/r/rwelande/test_directory")
+res = client.file.make_dir(directory_resource)
+
+# touchfile
+touch_resource = Resource.from_file_ref_and_endpoint("/eos/user/r/rwelande/touch_file.txt")
+res = client.file.touch_file(touch_resource)
+
+# setxattr
+resource = Resource.from_file_ref_and_endpoint("/eos/user/r/rwelande/text_file.txt")
+res = client.file.set_xattr(resource, "iop.wopi.lastwritetime", str(1720696124))
+
+# rmxattr
+res = client.file.remove_xattr(resource, "iop.wopi.lastwritetime")
+
+# stat
+res = client.file.stat(resource)
+
+# removefile
+res = client.file.remove_file(touch_resource)
+
+# rename
+rename_resource = Resource.from_file_ref_and_endpoint("/eos/user/r/rwelande/rename_file.txt")
+res = client.file.rename_file(resource, rename_resource)
+
+# writefile
+content = b"Hello World"
+size = len(content)
+res = client.file.write_file(rename_resource, content, size)
+
+# listdir
+list_directory_resource = Resource.from_file_ref_and_endpoint("/eos/user/r/rwelande")
+res = client.file.list_dir(list_directory_resource)
+
+
+# readfile
+file_res = client.file.read_file(rename_resource)
+```
+
+### Share Example
+```python
+# Create share #
+resource = Resource.from_file_ref_and_endpoint("/eos/user/r/<some_username>/text.txt")
+resource_info = client.file.stat(resource)
+user = client.user.get_user_by_claim("username", "<some_username>")
+res = client.share.create_share(resource_info, user.id.opaque_id, user.id.idp, "EDITOR", "USER")
+
+# List existing shares #
+filter_list = []
+filter = client.share.create_share_filter(resource_id=resource_info.id, filter_type="TYPE_RESOURCE_ID")
+filter_list.append(filter)
+filter = client.share.create_share_filter(share_state="SHARE_STATE_PENDING", filter_type="TYPE_STATE")
+filter_list.append(filter)
+res, _ = client.share.list_existing_shares()
+
+# Get share #
+share_id = "58"
+res = client.share.get_share(opaque_id=share_id)
+
+# update share #
+res = client.share.update_share(opaque_id=share_id, role="VIEWER")
+
+# remove share #
+res = client.share.remove_share(opaque_id=share_id)
+
+# List existing received shares #
+filter_list = []
+filter = client.share.create_share_filter(share_state="SHARE_STATE_ACCEPTED", filter_type="TYPE_STATE")
+filter_list.append(filter)
+res, _ = client.share.list_received_existing_shares()
+
+# get received share #
+received_share = client.share.get_received_share(opaque_id=share_id)
+
+# update recieved share #
+res = client.share.update_received_share(received_share=received_share, state="SHARE_STATE_ACCEPTED")
+
+# create public share #
+res = client.share.create_public_share(resource_info, role="VIEWER")
+
+# list existing public shares #
+filter_list = []
+filter = client.share.create_public_share_filter(resource_id=resource_info.id, filter_type="TYPE_RESOURCE_ID")
+filter_list.append(filter)
+res, _ = client.share.list_existing_public_shares(filter_list=filter_list)
+
+res = client.share.get_public_share(opaque_id=share_id, sign=True)
+# OR token = "<token>"
+# res = client.share.get_public_share(token=token, sign=True)
+
+# update public share #
+res = client.share.update_public_share(type="TYPE_PASSWORD", token=token, role="VIEWER", password="hello")
+
+# remove public share #
+res = client.share.remove_public_share(token=token)
+
+```
+
+### User Example
+```python
+# find_user
+res = client.user.find_users("rwel")
+
+# get_user
+res = client.user.get_user("https://auth.cern.ch/auth/realms/cern", "asdoiqwe")
+
+# get_user_groups
+res = client.user.get_user_groups("https://auth.cern.ch/auth/realms/cern", "rwelande")
+
+# get_user_by_claim (mail)
+res = client.user.get_user_by_claim("mail", "[email protected]")
+
+# get_user_by_claim (username)
+res = client.user.get_user_by_claim("username", "rwelande")
+
+```
+
+### App Example
+```python
+# list_app_providers
+res = client.app.list_app_providers()
+
+# open_in_app
+resource = Resource.from_file_ref_and_endpoint("/eos/user/r/rwelande/collabora.odt")
+res = client.app.open_in_app(resource)
+```
+
+### Checkpoint Example
+```python
+# list file versions
+resource = Resource.from_file_ref_and_endpoint("/eos/user/r/rwelande/test.md")
+res = client.checkpoint.list_file_versions(resource)
+
+# restore file version
+res = client.checkpoint.restore_file_version(resource, "1722936250.0569fa2f")
+```
+
+## Documentation
+The documentation can be generated using sphinx
+
+```bash
+pip install sphinx
+cd docs
+make html
+```
+
+## Unit tests
+
+```bash
+pytest --cov-report term --cov=serc tests/
+```
+
+## License
+
+This project is licensed under the Apache 2.0 License. See the LICENSE file for more details.

README.md

@@ -195,10 +195,12 @@ def get_file_ref_str(self):
         Generates a string from the file ref, '<type>="fileref">'
 
         :return: str '<type>="fileref">'
+        :raises: ValueError (Invalid Resource)
         """
         if self._abs_path:
             return f'absolute_path="{self._abs_path}"'
         elif self._rel_path:
             return f'relative_path="{self._parent_id}/{self._rel_path}"'
         elif self._opaque_id:
             return f'opaque_id="{self._opaque_id}"'
+        raise ValueError("Invalid Resource")

src/cs3resource.py

@@ -62,3 +62,12 @@ class AlreadyExistsException(IOError):
 
     def __init__(self, message: str = ""):
         super().__init__(message)
+
+
+class UnimplementedException(Exception):
+    """
+    Standard error thrown when attempting to use a feature that is not implemented
+    """
+
+    def __init__(self, message: str = ""):
+        super().__init__(message)

src/exceptions/exceptions.py

@@ -493,7 +493,7 @@ def remove_public_share(self, token: str = None, opaque_id: str = None) -> None:
 
     @classmethod
     def _create_public_share_update(
-        self,
+        cls,
         type: str,
         role: str,
         password: str = None,