test(*): Code smell

Author: julienloizelet

tests/Integration/IpVerificationTest.php

@@ -4,11 +4,8 @@
 
 namespace CrowdSecBouncer\Tests\Integration;
 
-use CrowdSecBouncer\ApiCache;
-use CrowdSecBouncer\ApiClient;
 use CrowdSecBouncer\Bouncer;
 use CrowdSecBouncer\Constants;
-use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
 
@@ -49,7 +46,7 @@ public function testCanVerifyIpInLiveModeWithCacheSystem($cacheAdapterName, $ori
             'api_key' => TestHelpers::getBouncerKey(),
             'api_url' => TestHelpers::getLapiUrl(),
             'use_curl' => $this->useCurl,
-            'api_user_agent' => 'Unit test/'.Constants::BASE_USER_AGENT,
+            'api_user_agent' => TestHelpers::UNIT_TEST_AGENT_PREFIX . '/' . Constants::BASE_USER_AGENT,
             'cache_system' => $cacheAdapterName,
             'redis_dsn' => getenv('REDIS_DSN'),
             'memcached_dsn' =>  getenv('MEMCACHED_DSN'),
@@ -159,7 +156,7 @@ public function testCanVerifyIpInStreamModeWithCacheSystem($cacheAdapterName, $o
         $bouncerConfigs = [
             'api_key' => TestHelpers::getBouncerKey(),
             'api_url' => TestHelpers::getLapiUrl(),
-            'api_user_agent' => 'Unit test/'.Constants::BASE_USER_AGENT,
+            'api_user_agent' => TestHelpers::UNIT_TEST_AGENT_PREFIX . '/' . Constants::BASE_USER_AGENT,
             'stream_mode' => true,
             'use_curl' => $this->useCurl,
             'cache_system' => $cacheAdapterName,
@@ -260,7 +257,7 @@ public function testCanVerifyIpInStreamModeWithCacheSystem($cacheAdapterName, $o
             'api_url' => TestHelpers::getLapiUrl(),
             'stream_mode' => true,
             'use_curl' => $this->useCurl,
-            'api_user_agent' => 'Unit test/'.Constants::BASE_USER_AGENT,
+            'api_user_agent' => TestHelpers::UNIT_TEST_AGENT_PREFIX . '/' . Constants::BASE_USER_AGENT,
             'cache_system' => $cacheAdapterName,
             'redis_dsn' => getenv('REDIS_DSN'),
             'memcached_dsn' =>  getenv('MEMCACHED_DSN'),

tests/Integration/TestHelpers.php

@@ -28,6 +28,7 @@ class TestHelpers
     public const JAPAN = 'JP';
     public const IP_JAPAN = '210.249.74.42';
     public const IP_FRANCE = '78.119.253.85';
+    public const UNIT_TEST_AGENT_PREFIX = 'Unit test';
 
     public const PHP_FILES_CACHE_ADAPTER_DIR = __DIR__.'/../var/phpFiles.cache';