style(*): Clean some code

Author: julienloizelet

src/ApiCache.php

@@ -694,8 +694,10 @@ private function hit(string $ip): string
     }
 
     /**
+     * @param string $cacheScope
      * @param $value
      *
+     * @return string
      * @throws InvalidArgumentException
      * @throws Exception
      */

src/Bouncer.php

@@ -31,9 +31,6 @@ class Bouncer
     /** @var LoggerInterface */
     private $logger;
 
-    /** @var array */
-    private $config = [];
-
     /** @var ApiCache */
     private $apiCache;
 
@@ -62,25 +59,25 @@ public function configure(array $config): void
         // Process input configuration.
         $configuration = new Configuration();
         $processor = new Processor();
-        $this->config = $processor->processConfiguration($configuration, [$config]);
+        $finalConfig = $processor->processConfiguration($configuration, [$config]);
         /** @var int */
         $index = array_search(
-            $this->config['max_remediation_level'],
+            $finalConfig['max_remediation_level'],
             Constants::ORDERED_REMEDIATIONS
         );
         $this->maxRemediationLevelIndex = $index;
 
         // Configure Api Cache.
         $this->apiCache->configure(
-            $this->config['stream_mode'],
-            $this->config['api_url'],
-            $this->config['api_timeout'],
-            $this->config['api_user_agent'],
-            $this->config['api_key'],
-            $this->config['cache_expiration_for_clean_ip'],
-            $this->config['cache_expiration_for_bad_ip'],
-            $this->config['fallback_remediation'],
-            $this->config['geolocation']
+            $finalConfig['stream_mode'],
+            $finalConfig['api_url'],
+            $finalConfig['api_timeout'],
+            $finalConfig['api_user_agent'],
+            $finalConfig['api_key'],
+            $finalConfig['cache_expiration_for_clean_ip'],
+            $finalConfig['cache_expiration_for_bad_ip'],
+            $finalConfig['fallback_remediation'],
+            $finalConfig['geolocation']
         );
     }
 

src/Constants.php

@@ -16,9 +16,6 @@
  */
 class Constants
 {
-    /** @var string The URL of the CrowdSec Central API */
-    public const CAPI_URL = 'https://api.crowdsec.net/v2/';
-
     /** @var string The Default URL of the CrowdSec LAPI */
     public const DEFAULT_LAPI_URL = 'http://localhost:8080';
 

src/StandaloneBounce.php

@@ -92,10 +92,10 @@ private function getCacheAdapterInstance(bool $forceReload = false): AbstractAda
                 } catch (InvalidArgumentException $e) {
                     throw new BouncerException('Error when connecting to Redis.'.' Please fix the Redis DSN or select another cache technology.');
                 }
-
                 break;
+
             default:
-                throw new BouncerException('Unknown selected cache technology.');
+                throw new BouncerException("Unknown selected cache technology: $cacheSystem");
         }
 
         return $this->cacheAdapter;