Skip to content

Commit 84e18c6

Browse files
committed
fix ci for php8
1 parent 6531cf9 commit 84e18c6

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

.github/workflows/tests.yml

-4
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,6 @@ jobs:
4848
- name: Add a machine to pilot crowdsec state
4949
run: docker exec crowdsec cscli machines add PhpUnitTestMachine --password PhpUnitTestMachinePassword
5050

51-
- name: Install libmemcached
52-
if: matrix.php == '8.0' # required only for php 8 as mentioned here: https://github.com/shivammathur/setup-php/issues/354
53-
run: sudo apt-get install libmemcached-dev -y
54-
5551
- name: Setup PHP
5652
uses: shivammathur/setup-php@v2
5753
with:

docs/contribute.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ git branch -m <new-name>
8080
git push origin :<old-name> && git push origin <new-name>
8181

8282
# Create PR
83-
gh pr create --fill
83+
gh pr create --fill --web
8484
```
8585

8686
> Note: after the merge, don't forget to delete to branch.

0 commit comments

Comments
 (0)