feat(*): Fix some psalm warning

Author: julienloizelet

CHANGELOG.md

@@ -5,6 +5,19 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 
+## [0.34.0](https://github.com/crowdsecurity/php-cs-bouncer/releases/tag/v0.34.0) - 2022-11-24
+[_Compare with previous release_](https://github.com/crowdsecurity/php-cs-bouncer/compare/v0.33.0...v0.34.0)
+
+### Changed
+- Do not cache bypass decision in stream mode
+- Replace unauthorized chars by underscore `_` in cache key
+
+### Fixed
+- Fix decision duration parsing when it uses milliseconds
+
+---
+
+
 ## [0.33.0](https://github.com/crowdsecurity/php-cs-bouncer/releases/tag/v0.33.0) - 2022-11-10
 [_Compare with previous release_](https://github.com/crowdsecurity/php-cs-bouncer/compare/v0.32.0...v0.33.0)
 

src/AbstractCache.php

@@ -292,7 +292,8 @@ protected function addRemediationToCacheItem(
         ]; // erase previous decision with the same id
 
         // Build the item lifetime in cache and sort remediations by priority
-        $maxLifetime = max(array_column($remediations, 1));
+        $exps = array_column($remediations, 1);
+        $maxLifetime = $exps ? max($exps) : 0;
         $prioritizedRemediations = Remediation::sortRemediationByPriority($remediations);
 
         $item->set($prioritizedRemediations);
@@ -427,7 +428,7 @@ protected function miss(string $value, string $cacheScope): string
             }
         }
         // In stream mode, we do not save bypass decision in cache
-        if($this->streamMode && !$decisions){
+        if ($this->streamMode && !$decisions) {
             return Constants::REMEDIATION_BYPASS;
         }
 
@@ -469,7 +470,8 @@ protected function removeDecisionFromRemediationItem(string $cacheKey, int $deci
             return true;
         }
         // Build the item lifetime in cache and sort remediations by priority
-        $maxLifetime = max(array_column($remediations, 1));
+        $exps = array_column($remediations, 1);
+        $maxLifetime = $exps ? max($exps) : 0;
         $cacheContent = Remediation::sortRemediationByPriority($remediations);
         $item->expiresAt(new DateTime('@' . $maxLifetime));
         $item->set($cacheContent);

src/RestClient/Curl.php

@@ -51,8 +51,6 @@ public function request(
     }
 
     /**
-     * @param $handle
-     *
      * @return bool|string
      */
     protected function exec($handle)
@@ -61,8 +59,6 @@ protected function exec($handle)
     }
 
     /**
-     * @param $handle
-     *
      * @return mixed
      */
     protected function getResponseHttpCode($handle)