Merge pull request #34 from crowdsecurity/fix-long-duration

mobula9 · web-flow · commit 000eee43c37e · 2021-01-04T18:42:42.000+01:00
fix memached edge case
diff --git a/src/ApiCache.php b/src/ApiCache.php
@@ -213,7 +213,7 @@ private function formatRemediationFromDecision(?array $decision): array
             $duration = time() + $this->cacheExpirationForCleanIp;
             if (!$this->liveMode) {
                 // In stream mode we considere an clean IP forever... until the next resync.
-                $duration = \PHP_INT_MAX;
+                $duration = 315360000; // in this case, forever is 10 years as PHP_INT_MAX will cause trouble with the Memcached Adapter (int to float unwanted conversion)
             }
 
             return [Constants::REMEDIATION_BYPASS, $duration, 0];

Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,7 @@ private function formatRemediationFromDecision(?array $decision): array`
`213`	`213`	`$duration = time() + $this->cacheExpirationForCleanIp;`
`214`	`214`	`if (!$this->liveMode) {`
`215`	`215`	`// In stream mode we considere an clean IP forever... until the next resync.`
`216`		`- $duration = \PHP_INT_MAX;`
	`216`	`+ $duration = 315360000; // in this case, forever is 10 years as PHP_INT_MAX will cause trouble with the Memcached Adapter (int to float unwanted conversion)`
`217`	`217`	`}`
`218`	`218`
`219`	`219`	`return [Constants::REMEDIATION_BYPASS, $duration, 0];`