Skip to content
This repository was archived by the owner on Apr 3, 2020. It is now read-only.

Commit b403e97

Browse files
committed
Fix XDK code so that it uses size_t instead of int.
This is useful to support 64 bits because call sites of that API usually uses std functions which returns a size_t and size_t is not going to git into an int on 64 bits. Today it triggers a warning of potential data loss.
1 parent 45d85b8 commit b403e97

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Source/bindings/core/v8/ScriptProfiler.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -329,12 +329,12 @@ class HeapXDKStream : public v8::OutputStream {
329329
return kAbort;
330330
}
331331

332-
virtual WriteResult WriteHeapXDKChunk(const char* symbols, int symbolsSize,
333-
const char* frames, int framesSize,
334-
const char* types, int typesSize,
335-
const char* chunks, int chunksSize,
332+
virtual WriteResult WriteHeapXDKChunk(const char* symbols, size_t symbolsSize,
333+
const char* frames, size_t framesSize,
334+
const char* types, size_t typesSize,
335+
const char* chunks, size_t chunksSize,
336336
const char* retentions,
337-
int retentionSize) override
337+
size_t retentionSize) override
338338
{
339339
m_stream->write(symbols, symbolsSize, frames, framesSize,
340340
types, typesSize, chunks, chunksSize,

0 commit comments

Comments
 (0)