Skip to content

Commit f0ec688

Browse files
authored
Fix illumos BINDGEN_EXTRA_CLANG_ARGS (#1651)
Hello! The Docker image for `x86_64-unknown-illumos` specifies a `BINDGEN_EXTRA_CLANG_ARGS` variable for `sparcv9_sun_solaris`. I noticed while working on this PR: aws/aws-lc-rs#709 This commit updates the name of the variable to match the intended target.
2 parents 36c0d78 + c1eb2c8 commit f0ec688

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

.changes/1651.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"description": "Fix BINDGEN_EXTRA_CLANG_ARGS for x86_64-unknown-illumos",
3+
"issues": [1644],
4+
"type": "fixed",
5+
"breaking": false
6+
}

docker/Dockerfile.x86_64-unknown-illumos

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ ENV PATH=$PATH:/usr/local/x86_64-unknown-illumos/bin/ \
2525
CC_x86_64_unknown_illumos="$CROSS_TOOLCHAIN_PREFIX"gcc \
2626
CXX_x86_64_unknown_illumos="$CROSS_TOOLCHAIN_PREFIX"g++ \
2727
CMAKE_TOOLCHAIN_FILE_x86_64_unknown_illumos=/opt/toolchain.cmake \
28-
BINDGEN_EXTRA_CLANG_ARGS_sparcv9_sun_solaris="--sysroot=$CROSS_SYSROOT" \
28+
BINDGEN_EXTRA_CLANG_ARGS_x86_64_unknown_illumos="--sysroot=$CROSS_SYSROOT" \
2929
CROSS_CMAKE_SYSTEM_NAME=illumos \
3030
CROSS_CMAKE_SYSTEM_PROCESSOR=x86_64 \
3131
CROSS_CMAKE_CRT=solaris \

0 commit comments

Comments
 (0)