Skip to content

Commit 8daa945

Browse files
committed
Chmod package internal folder perm after unzip
Update release note for 1.11.1
1 parent 4c2c3dc commit 8daa945

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

internal/pkg/zip-package.go

+11-7
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,17 @@ func (pkg *zipPackage) InstallTo(targetDir string) (command.PackageManifest, err
5959
extractedFilePath := filepath.Join(targetDir, file.Name)
6060
if file.FileInfo().IsDir() {
6161
log.Println("Directory Created:", extractedFilePath)
62-
if os.Stat(extractedFilePath); os.IsNotExist(err) {
63-
// create the folder if it does not exist
64-
err := os.MkdirAll(extractedFilePath, 0755)
65-
if err != nil {
66-
return nil, fmt.Errorf("directory extraction failed: %s", err)
67-
}
68-
} else {
62+
err := os.MkdirAll(extractedFilePath, file.Mode())
63+
if err != nil {
64+
return nil, fmt.Errorf("directory extraction failed: %s", err)
65+
}
66+
67+
fileStats, err := os.Stat(extractedFilePath)
68+
if err != nil {
69+
return nil, fmt.Errorf("failed to stat %s: %s", extractedFilePath, err)
70+
}
71+
permissions := fileStats.Mode().Perm()
72+
if permissions != 0o755 {
6973
// chmod to 755
7074
if err := os.Chmod(extractedFilePath, 0755); err != nil {
7175
return nil, fmt.Errorf("failed to chmod %s to 0755: %s", extractedFilePath, err)

release-notes.yaml

+7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
1.11.1:
2+
version: 1.11.1
3+
releaseNotes: |
4+
* 🐛 Change package internal folder permisison issue after unzip
5+
startPartition: 0
6+
endPartition: 9
7+
18
1.11.0:
29
version: 1.11.0
310
releaseNotes: |

0 commit comments

Comments
 (0)