Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Any plans or interest in dockerizing this "monster"? :) #4

Open
frankis opened this issue Sep 28, 2017 · 3 comments
Open

Q: Any plans or interest in dockerizing this "monster"? :) #4

frankis opened this issue Sep 28, 2017 · 3 comments
Labels

Comments

@frankis
Copy link

frankis commented Sep 28, 2017

No description provided.

@crisbal
Copy link
Owner

crisbal commented Sep 28, 2017

I don't see a point in dockerizing this. The only advantage I see in dockerizing is that it will cut download times a little bit but it does make everything else a little bit harder. Since it is only a nodejs project one can git-clone the project and simply run npm install.

Well, actually we could provide a Dockerfile in the repository as an example but it could be seen out of scope and very simple (It would just be installing the packages, exposing the port and setting the run script).

If you have any other good reason to use docker in the project please let me know.

@distortia
Copy link

I think it would be good to dockerize it. As the community and project matures, we should be looking into deployments strategies and the best course of action for the future.

That said, we currently dockerize it on our own, but would love to chat with others regarding how they handle things. Since every project handles things different and how they integrate it into their stack/use cases. We all come back to this repo 👍

@crisbal
Copy link
Owner

crisbal commented Oct 17, 2017

@Gingernaut submitted a pull request with an example Dockerfile here

Since there is interest I will consider more adding a Dockerfile, in the meanwhile the PR gives a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants