You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The copy code is mostly a call to io.Copy(out, in), if there are improvements to be made, they may belong to this module. Or could it be a fsync/no fsync difference?
Btw, defer out.Close() is frowned upon as we could miss errors (https://www.joeshaw.org/dont-defer-close-on-writable-files/ )
On my machine, the bundle copy from the cache to the machine directory takes around 6s with the Go code.
With
cp
it takes 4s.Related code: https://github.com/code-ready/machine-driver-hyperkit/blob/master/pkg/hyperkit/copy.go#L8
The text was updated successfully, but these errors were encountered: