Add python 3.8 support

Author: mfussenegger

.github/workflows/main.yml

@@ -11,7 +11,7 @@ jobs:
       matrix:
         os: [ubuntu-latest]
         sqla-version: ['1.1.15', '1.2.18']
-        python-version: [3.5, 3.6, 3.7]
+        python-version: [3.5, 3.6, 3.7, 3.8]
 
     steps:
       - uses: actions/checkout@master

CHANGES.txt

@@ -5,6 +5,8 @@ Changes for crate
 Unreleased
 ==========
 
+- Added official Python 3.8 support.
+
 - Made it so that the SQLAlchemy dialect is now aware of the return type of the
   ``date_trunc`` function.
 

setup.cfg

@@ -2,4 +2,4 @@
 universal = 1
 
 [flake8]
-ignore = E501,C901
+ignore = E501,C901, W504

setup.py

@@ -85,6 +85,7 @@ def read(path):
         'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
+        'Programming Language :: Python :: 3.8',
         'Programming Language :: Python :: Implementation :: CPython',
         'Programming Language :: Python :: Implementation :: PyPy',
         'Topic :: Database'

src/crate/client/sqlalchemy/dialect.py

@@ -246,7 +246,7 @@ def get_columns(self, connection, table_name, schema=None, **kw):
             query,
             [table_name,
              schema or self.default_schema_name,
-             "(.*)\[\'(.*)\'\]"]  # regex to filter subscript
+             r"(.*)\[\'(.*)\'\]"]  # regex to filter subscript
         )
         return [self._create_column_info(row) for row in cursor.fetchall()]
 

src/crate/client/sqlalchemy/tests/array_test.py

@@ -44,17 +44,17 @@ def setUp(self):
         self.metadata = sa.MetaData()
 
         class User(Base):
-                __tablename__ = 'users'
+            __tablename__ = 'users'
 
-                name = sa.Column(sa.String, primary_key=True)
-                friends = sa.Column(sa.ARRAY(sa.String))
-                scores = sa.Column(sa.ARRAY(sa.Integer))
+            name = sa.Column(sa.String, primary_key=True)
+            friends = sa.Column(sa.ARRAY(sa.String))
+            scores = sa.Column(sa.ARRAY(sa.Integer))
 
         self.User = User
         self.session = Session()
 
     def assertSQL(self, expected_str, actual_expr):
-            self.assertEqual(expected_str, str(actual_expr).replace('\n', ''))
+        self.assertEqual(expected_str, str(actual_expr).replace('\n', ''))
 
     def test_create_with_array(self):
         t1 = sa.Table('t', self.metadata,

src/crate/testing/tests.py

@@ -56,11 +56,12 @@ def setUp(test):
 
 def test_suite():
     suite = unittest.TestSuite()
-    s = doctest.DocFileSuite('doctests/layer.txt',
-                             setUp=setUp,
-                             optionflags=doctest.NORMALIZE_WHITESPACE |
-                             doctest.ELLIPSIS,
-                             encoding='utf-8')
+    s = doctest.DocFileSuite(
+        'doctests/layer.txt',
+        setUp=setUp,
+        optionflags=doctest.NORMALIZE_WHITESPACE | doctest.ELLIPSIS,
+        encoding='utf-8'
+    )
     suite.addTest(s)
     suite.addTest(unittest.makeSuite(LayerUtilsTest))
     return suite

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py{py,34,35,36,37}-sa_{1_0,1_1,1_2}
+envlist = py{py,34,35,36,37,38}-sa_{1_0,1_1,1_2}
 
 [testenv]
 usedevelop = True

versions.cfg

@@ -1,18 +1,18 @@
 [versions]
 crate_server = 4.0.2
 
-flake8 = 2.5.1
-mccabe = 0.3.1
-pep8 = 1.5.7
-pyflakes = 1.0.0
+flake8 = 3.7.9
+mccabe = 0.6.1
+pep8 = 1.7.1
+pyflakes = 2.1.1
 Jinja2 = 2.7.3
 MarkupSafe = 0.23
 Pygments = 1.6
 Sphinx = 1.2.3
 SQLAlchemy = 1.2.0
-coverage = 3.7.1
+coverage = 5.0.3
 crate-docs-theme = 0.5.0
-createcoverage = 1.2
+createcoverage = 1.5
 docutils = 0.12
 hexagonit.recipe.download = 1.7
 py = 1.4.26