Skip to content

Commit 0257794

Browse files
committed
SA14/Tests: Do not pass params=None to crate_before_execute
Specifically, for the non-bulk case. In case of validating bulk updates, it is still left to `None`. Croaks otherwise:: File "/Users/amo/dev/crate/sources/crate-python/src/crate/client/sqlalchemy/tests/compiler_test.py", line 58, in test_crate_update_rewritten assert hasattr(clauseelement, '_crate_specific') is True AssertionError
1 parent d2c1dad commit 0257794

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/crate/client/sqlalchemy/tests/compiler_test.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,14 @@ def setUp(self):
4545

4646
def test_sqlite_update_not_rewritten(self):
4747
clauseelement, multiparams, params = crate_before_execute(
48-
self.sqlite_engine, self.update, self.values, None
48+
self.sqlite_engine, self.update, self.values, {}
4949
)
5050

5151
assert hasattr(clauseelement, '_crate_specific') is False
5252

5353
def test_crate_update_rewritten(self):
5454
clauseelement, multiparams, params = crate_before_execute(
55-
self.crate_engine, self.update, self.values, None
55+
self.crate_engine, self.update, self.values, {}
5656
)
5757

5858
assert hasattr(clauseelement, '_crate_specific') is True

0 commit comments

Comments
 (0)