Skip to content

Commit 1b03292

Browse files
committed
fix: resolve comments and fix e2e tests
1 parent b77a5f5 commit 1b03292

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

contracts/interfaces/IIBCPausable.sol

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
pragma solidity ^0.8.28;
33

44
interface IIBCPausable {
5-
/// @notice The role identifier for the unpauser role
5+
/// @notice The role identifier for the pauser role
66
function PAUSER_ROLE() external view returns (bytes32);
77

8-
/// @notice The role identifier for the ununpauser role
8+
/// @notice The role identifier for the unpauser role
99
function UNPAUSER_ROLE() external view returns (bytes32);
1010

1111
/// @notice Pauses the contract
@@ -16,12 +16,12 @@ interface IIBCPausable {
1616
/// @dev The caller must have the unpauser role
1717
function unpause() external;
1818

19-
/// @notice Grants the unpauser role to an account
19+
/// @notice Grants the pauser role to an account
2020
/// @dev The caller must be authorized by the derived contract
2121
/// @param account The account to grant the role to
2222
function grantPauserRole(address account) external;
2323

24-
/// @notice Revokes the unpauser role from an account
24+
/// @notice Revokes the pauser role from an account
2525
/// @dev The caller must be authorized by the derived contract
2626
/// @param account The account to revoke the role from
2727
function revokePauserRole(address account) external;

contracts/utils/IBCPausableUpgradeable.sol

+4-2
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@ abstract contract IBCPausableUpgradeable is
1616
{
1717
/// @inheritdoc IIBCPausable
1818
bytes32 public constant PAUSER_ROLE = keccak256("PAUSER_ROLE");
19+
/// @inheritdoc IIBCPausable
1920
bytes32 public constant UNPAUSER_ROLE = keccak256("UNPAUSER_ROLE");
2021

2122
/// @dev Initializes the contract in unpaused state.
22-
/// @param pauser The address that can pause and unpause the contract
23+
/// @param pauser The address that is granted the `PAUSER_ROLE`
24+
/// @param unpauser The address that is granted the `UNPAUSER_ROLE`
2325
function __IBCPausable_init(address pauser, address unpauser) internal onlyInitializing {
2426
__Pausable_init();
2527
__AccessControl_init();
@@ -39,7 +41,7 @@ abstract contract IBCPausableUpgradeable is
3941
}
4042

4143
/// @inheritdoc IIBCPausable
42-
function unpause() external virtual onlyRole(UNPAUSER_ROLE) {
44+
function unpause() external onlyRole(UNPAUSER_ROLE) {
4345
_unpause();
4446
}
4547

scripts/E2ETestDeploy.s.sol

+1
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ contract E2ETestDeploy is Script, IICS07TendermintMsgs, DeploySP1ICS07Tendermint
7777
escrowImplementation: escrowLogic,
7878
ibcERC20Implementation: ibcERC20Logic,
7979
pauser: address(0),
80+
unpauser: address(0),
8081
permit2: address(0)
8182
});
8283

0 commit comments

Comments
 (0)