Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube detected as a browser #73

Closed
wiiznokes opened this issue Dec 24, 2024 · 3 comments
Closed

Youtube detected as a browser #73

wiiznokes opened this issue Dec 24, 2024 · 3 comments

Comments

@wiiznokes
Copy link
Contributor

I have no idea where this come from

Capture d’écran du 2024-12-24 02-53-41

@wiiznokes
Copy link
Contributor Author

I think it's due to a web apps that was installed directly from Brave (and was not visible by default somehow)

~/.local/share/applications$ cat ./com.brave.Browser.flextop.brave-agimnkijcaahngcdmfeangaknmldooml-Default.desktop 
#!/usr/bin/env xdg-open
[Desktop Entry]
Version=1.0
Terminal=false
Type=Application
Name=YouTube
Exec=flatpak 'run' '--command=brave' 'com.brave.Browser' '--profile-directory=Default' '--app-id=agimnkijcaahngcdmfeangaknmldooml'
Icon=brave-agimnkijcaahngcdmfeangaknmldooml-Default
NoDisplay=true
StartupWMClass=crx_agimnkijcaahngcdmfeangaknmldooml
Actions=Abonnements;Explorer
X-Flatpak-Part-Of=com.brave.Browser
TryExec=/var/lib/flatpak/exports/bin/com.brave.Browser

[Desktop Action Abonnements]
Name=Abonnements
Exec=flatpak 'run' '--command=brave' 'com.brave.Browser' '--profile-directory=Default' '--app-id=agimnkijcaahngcdmfeangaknmldooml' '--app-launch-url-for-shortcuts-menu-item=https://www.youtube.com/feed/subscriptions?feature=app_shortcuts'

[Desktop Action Explorer]
Name=Explorer
Exec=flatpak 'run' '--command=brave' 'com.brave.Browser' '--profile-directory=Default' '--app-id=agimnkijcaahngcdmfeangaknmldooml' '--app-launch-url-for-shortcuts-menu-item=https://www.youtube.com/feed/explore?feature=app_shortcuts'

Not sure what'is the best way to find and identify installed web browsers, but just just exec.contains() will not work every time.

I think using an exact match on the appid could work ?

@hepp3n
Copy link
Collaborator

hepp3n commented Dec 25, 2024

Well.

I think using an exact match on the appid could work ?

That how it was before. But changed due to this: #60 (comment)

Probably I should just add new entry to supported browsers with new firefox's id. I changed this search algorithm a bit and now it causes issues :( I probably should change it so let me fix it soon.

@hepp3n
Copy link
Collaborator

hepp3n commented Jan 28, 2025

Hello,

I made a bit of refactoring, ok maybe little bigger ^^ Many things changed. If you would like to test it now, how it will behave, it would be cool :)

@hepp3n hepp3n closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants