Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Choose PNG icon doesn't work #43

Closed
ZorinFoss opened this issue Jun 13, 2024 · 6 comments
Closed

[Bug] Choose PNG icon doesn't work #43

ZorinFoss opened this issue Jun 13, 2024 · 6 comments

Comments

@ZorinFoss
Copy link

ZorinFoss commented Jun 13, 2024

Hi,

After update to v0.4.6 which it support png, I try to choose png icon to app and it didn't work. The app create svg file with the app name APPNAME.svg instead.

Thanks,

@hepp3n
Copy link
Collaborator

hepp3n commented Jun 13, 2024

It converts png to svg for consistency. This way icons copied to your directory are all in one format.

@ZorinFoss
Copy link
Author

converted file is corrupted and empty.

@Tahinli
Copy link
Contributor

Tahinli commented Jun 21, 2024

I think I'm also seeing this, I added logo to my icons as png and it's in icons but when I selected logo just seems like broken.

@hepp3n
Copy link
Collaborator

hepp3n commented Jun 24, 2024

For me it works. Are you sure you trying to convert from png and not JPEG? It's the only issue comes to my mind for now.
The whole conversion process is only embedding png image as base64 encoded data into svg. But PNG is hard coded and it you trying to use JPEG for this, it can fail.

@Tahinli
Copy link
Contributor

Tahinli commented Jun 25, 2024

For me it works. Are you sure you trying to convert from png and not JPEG? It's the only issue comes to my mind for now. The whole conversion process is only embedding png image as base64 encoded data into svg. But PNG is hard coded and it you trying to use JPEG for this, it can fail.

mine was png

@edfloreshz edfloreshz moved this to Todo in WebApps Sep 4, 2024
@hepp3n
Copy link
Collaborator

hepp3n commented Jan 28, 2025

Should be fixed, actually some time ago.

@hepp3n hepp3n closed this as completed Jan 28, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in WebApps Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants