fix(plugin): close 4 reported correctness issues

1. Stale dream queue entries no longer block /ctx-dream — enqueueDream()
   now cleans started entries older than 10 minutes before rejecting.
2. Smart-note evaluation success no longer masks failed dream tasks —
   hasSuccessfulTask excludes the supplementary smart-notes task.
3. Note-nudge cooldown now checks unconditionally instead of only when
   sticky fields are present, preventing rapid trigger bypass.
4. FTS search failures are now logged instead of silently returning [].

Author: ualtinok

packages/plugin/src/features/magic-context/dreamer/queue.ts

@@ -34,12 +34,19 @@ export function enqueueDream(
 ): DreamQueueEntry | null {
     const now = Date.now();
     return db.transaction(() => {
+        // Clean stale started entries before checking — prevents post-crash permanent "already queued"
+        const staleThresholdMs = 10 * 60 * 1000; // 10 minutes
+        db.run(
+            "DELETE FROM dream_queue WHERE project_path = ? AND started_at IS NOT NULL AND started_at < ?",
+            [projectIdentity, now - staleThresholdMs],
+        );
+
         const existing = db
             .query<{ id: number }, [string]>("SELECT id FROM dream_queue WHERE project_path = ?")
             .get(projectIdentity);
 
         if (existing) {
-            return null; // already queued
+            return null; // already queued (fresh entry)
         }
 
         const result = db

packages/plugin/src/features/magic-context/dreamer/runner.ts

@@ -271,7 +271,9 @@ export async function runDream(args: {
     result.finishedAt = Date.now();
     // Only update dream timestamps when at least one task succeeded — failed runs
     // should not block re-scheduling for the project.
-    const hasSuccessfulTask = result.tasks.some((t) => !t.error);
+    // Only count configured dream tasks for success — smart-note evaluation is supplementary
+    // and should not mask failures of real tasks like consolidate/verify/archive-stale
+    const hasSuccessfulTask = result.tasks.some((t) => !t.error && t.name !== "smart-notes");
     if (hasSuccessfulTask) {
         setDreamState(args.db, `last_dream_at:${args.projectIdentity}`, String(result.finishedAt));
         setDreamState(args.db, "last_dream_at", String(result.finishedAt));

packages/plugin/src/features/magic-context/search.ts

@@ -15,6 +15,7 @@ import { embedText, isEmbeddingEnabled } from "./memory/embedding";
 import { sanitizeFtsQuery } from "./memory/storage-memory-fts";
 import { ensureMessagesIndexed } from "./message-index";
 import { getSessionFacts, type SessionFact } from "./storage";
+import { log } from "../../shared/logger";
 
 type PreparedStatement = ReturnType<Database["prepare"]>;
 
@@ -212,7 +213,8 @@ function getFtsMatches(args: {
 }): Memory[] {
     try {
         return searchMemoriesFTS(args.db, args.projectPath, args.query, args.limit);
-    } catch {
+    } catch (error) {
+        log(`[search] FTS query failed for "${args.query}": ${error instanceof Error ? error.message : String(error)}`);
         return [];
     }
 }

packages/plugin/src/hooks/magic-context/note-nudger.ts

@@ -94,16 +94,16 @@ export function peekNoteNudgeText(
     // Suppress if we delivered a nudge recently (within 15 minutes).
     // Prevents the same notes from being re-surfaced on every commit/todo boundary
     // in quick succession during active work.
-    if (state.stickyText && state.stickyMessageId) {
-        const deliveredAt = getPersistedNoteNudgeDeliveredAt(db, sessionId);
-        if (deliveredAt > 0 && Date.now() - deliveredAt < NOTE_NUDGE_COOLDOWN_MS) {
-            sessionLog(
-                sessionId,
-                `note-nudge: suppressing — last delivered ${Math.round((Date.now() - deliveredAt) / 1000)}s ago (cooldown ${NOTE_NUDGE_COOLDOWN_MS / 60000}m)`,
-            );
-            clearPersistedNoteNudge(db, sessionId);
-            return null;
-        }
+    // Check unconditionally — a new trigger clears sticky fields, so gating on
+    // stickyText presence would let triggers bypass the cooldown window.
+    const deliveredAt = getPersistedNoteNudgeDeliveredAt(db, sessionId);
+    if (deliveredAt > 0 && Date.now() - deliveredAt < NOTE_NUDGE_COOLDOWN_MS) {
+        sessionLog(
+            sessionId,
+            `note-nudge: suppressing — last delivered ${Math.round((Date.now() - deliveredAt) / 1000)}s ago (cooldown ${NOTE_NUDGE_COOLDOWN_MS / 60000}m)`,
+        );
+        clearPersistedNoteNudge(db, sessionId);
+        return null;
     }
 
     // Check if there are actually notes to remind about
@@ -177,4 +177,5 @@ export function getNoteNudgeText(db: Database, sessionId: string): string | null
  */
 export function clearNoteNudgeState(db: Database, sessionId: string): void {
     clearPersistedNoteNudge(db, sessionId);
+    lastDeliveredAt.delete(sessionId); // also reset in-memory cooldown
 }