refactor(AssetUploader): extract 'imageable' methods to concern

Author: toastercup

app/uploaders/asset_uploader.rb

@@ -3,6 +3,7 @@
 
 class AssetUploader < Shrine
   include ImageProcessing::MiniMagick
+  include Imageable
 
   plugin :determine_mime_type
   plugin :store_dimensions
@@ -50,31 +51,4 @@ def generate_location(io, context)
 
     ERB.new(context[:config][:metadata][:path]).result(binding)
   end
-
-  def image?(io)
-    MimeMagic.new(io.data['metadata']['mime_type']).mediatype == 'image'
-  end
-
-  private
-
-  def optimize_image!(image, image_optim)
-    pathname = image_optim.optimize_image!(image) # TODO: move to ActiveJob
-    pathname ? pathname.open : image
-  end
-
-  def image_optim_for(image_optim_config)
-    ImageOptim.new(process_image_optim_config(image_optim_config))
-  end
-
-  def process_image_optim_config(image_optim_config)
-    processed_image_optim_config = image_optim_config.merge(pngout: false, svgo: false, verbose: true, skip_missing_workers: false)
-    processed_image_optim_config.extend(Hashie::Extensions::DeepLocate)
-    quality_range_hashes = processed_image_optim_config.deep_locate -> (key, value, object) { key == :quality_range }
-    quality_range_hashes.each do |quality_range_hash|
-      quality_range_hash[:quality] = quality_range_hash[:quality_range][:begin]..quality_range_hash[:quality_range][:end]
-      quality_range_hash.delete(:quality_range)
-    end
-
-    processed_image_optim_config
-  end
 end

app/uploaders/concerns/imageable.rb

@@ -0,0 +1,30 @@
+module Imageable
+  extend ActiveSupport::Concern
+
+  included do
+    def image?(io)
+      MimeMagic.new(io.data['metadata']['mime_type']).mediatype == 'image'
+    end
+
+    def optimize_image!(image, image_optim)
+      pathname = image_optim.optimize_image!(image) # TODO: move to ActiveJob
+      pathname ? pathname.open : image
+    end
+
+    def image_optim_for(image_optim_config)
+      ImageOptim.new(process_image_optim_config(image_optim_config))
+    end
+
+    def process_image_optim_config(image_optim_config)
+      processed_image_optim_config = image_optim_config.merge(pngout: false, svgo: false, verbose: true, skip_missing_workers: false)
+      processed_image_optim_config.extend(Hashie::Extensions::DeepLocate)
+      quality_range_hashes = processed_image_optim_config.deep_locate -> (key, value, object) { key == :quality_range }
+      quality_range_hashes.each do |quality_range_hash|
+        quality_range_hash[:quality] = quality_range_hash[:quality_range][:begin]..quality_range_hash[:quality_range][:end]
+        quality_range_hash.delete(:quality_range)
+      end
+
+      processed_image_optim_config
+    end
+  end
+end